tasklist: NestedToken have no attr when is used without any text content about mdit-py-plugins HOT 7 CLOSED

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

from mdit-py-plugins.

thanks @shivam05011996 I will move this over to mdit_py_plugins

pinging @wna-se, who wrote that plugin and so might have some thoughts

from mdit-py-plugins.

Sure, but even if not GFM, we need some spec to adhere to. When it comes to task lists, at least I'm not aware of any alternatives. Also my understanding is @chrisjsewell wants to keep behavior as close to Javascript source as possible, and that targets GFM.

Understood.

The task list plugin here is just a Python port of the HackMd plugin so essentially the same. And that plugin does target GFM spec.

Yes, thank you I checked this and now I understand this much better.

Closing this issue and as this indeed is not a bug.

from mdit-py-plugins.

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

from mdit-py-plugins.

I believe a task list item without content is simply not a thing in GFM.

The GFM spec says

A task list item is a list item where the first block in it is a paragraph which begins with a task list item marker and at least one whitespace character before any other content.

Whether "any other content" is required to be there seems a bit ambiguous to me. But I guess GitHub's own parser (that parses these comments) can be seen as a reference implementation of sorts, and that parser thinks that - [ ] is not a task list item.

So I'm inclined to say - [ ] is not a task list item, and there is no bug.

from mdit-py-plugins.

I believe markdown_it_py is a general markdown down parser and not bound to adhere to GFM, because there are other renderers like HackMD.io which does this and that too uses markdown_it of parsing purposes however not the python port.

from mdit-py-plugins.

I believe markdown_it_py is a general markdown down parser and not bound to adhere to GFM

Sure, but even if not GFM, we need some spec to adhere to. When it comes to task lists, at least I'm not aware of any alternatives. Also my understanding is @chrisjsewell wants to keep behavior as close to Javascript source as possible, and that targets GFM.

there are other renderers like HackMD.io

The task list plugin here is just a Python port of the HackMd plugin so essentially the same. And that plugin does target GFM spec.

from mdit-py-plugins.