Comments (5)
The README is pretty ambiguous on purpose, though it probably should mention area codes for US/Canadian numbers.
I'm not sure what the right move is for the invalid phone numbers. I think different languages handle it differently. Go returns error values, I believe, and Ruby raises an ArgumentError.
from cpp.
In general I think the problem descriptions should describe the expected interface and be deliberately ambiguous on the implementation. In this case I would add a mention of area_code
. The tests handle invalid numbers by returning "0000000000" which is fine but should also be mentioned in the description.
from cpp.
The expected interface can be different for different languages which is why it's not in the problem description. As just a small example, the expected interface for a functional language is very different from an object-oriented language with exceptions, which in turn is very different for a procedural language without an exception mechanism.
The expected interface is defined by the tests provided by a particular language track and the problem description is purposefully kept vague enough that it doesn't try to prescribe any particular implementation.
from cpp.
Also, the C++ language track defines what the expected behavior is when invalid phone numbers are given. This is covered in tests such as invalid_when_11_digits.
from cpp.
Closing this issue as it is not related directly to the C++ track.
from cpp.
Related Issues (20)
- Missing semi-colon in 'interest-is-interesting' tutorial HOT 4
- Building a training set of tags for cpp HOT 26
- fix: spelling mistake in classes docs
- pop-count: The header file tab is missing. HOT 3
- doctor-data: typo HOT 2
- Doctor Data skeleton contains garbage HOT 2
- ESP-AT: CMake error: Does not match the generator used previously: Ninja HOT 3
- feat: add approaches for leap exercise
- Make double testing more robust for freelancer rates cocnept exercise
- Update test cases HOT 37
- Add #48in24 featured exercises HOT 19
- Tweak troll exercise
- Passthrough mode - I receive ERROR when I send a packet HOT 2
- log-levels concept exercise needs a more fleshed-out stub HOT 3
- parallell-letter-frequency tests are missing some assertions HOT 2
- CI: Only run tests on exercises, when exercise relevant files are changed
- Formatting check in CI is broken HOT 7
- disregard, wrong project :-/ HOT 1
- doctor-data task 4 "get_older_bob" is confusing HOT 1
- robot-name: tests are not sufficient when using mt19937 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cpp.