Giter VIP home page Giter VIP logo

Comments (5)

kytrinyx avatar kytrinyx commented on August 30, 2024

The README is pretty ambiguous on purpose, though it probably should mention area codes for US/Canadian numbers.

I'm not sure what the right move is for the invalid phone numbers. I think different languages handle it differently. Go returns error values, I believe, and Ruby raises an ArgumentError.

from cpp.

ekse avatar ekse commented on August 30, 2024

In general I think the problem descriptions should describe the expected interface and be deliberately ambiguous on the implementation. In this case I would add a mention of area_code. The tests handle invalid numbers by returning "0000000000" which is fine but should also be mentioned in the description.

from cpp.

LegalizeAdulthood avatar LegalizeAdulthood commented on August 30, 2024

The expected interface can be different for different languages which is why it's not in the problem description. As just a small example, the expected interface for a functional language is very different from an object-oriented language with exceptions, which in turn is very different for a procedural language without an exception mechanism.

The expected interface is defined by the tests provided by a particular language track and the problem description is purposefully kept vague enough that it doesn't try to prescribe any particular implementation.

from cpp.

LegalizeAdulthood avatar LegalizeAdulthood commented on August 30, 2024

Also, the C++ language track defines what the expected behavior is when invalid phone numbers are given. This is covered in tests such as invalid_when_11_digits.

from cpp.

ekse avatar ekse commented on August 30, 2024

Closing this issue as it is not related directly to the C++ track.

from cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.