Comments (2)
kotp
commented on June 10, 2024
Links to the files you are referencing would be nice :)
Grains exercise tests are definitely modifiable. And should not effect any solutions that I am aware of. The example.rb file uses a Class for no obvious (to me) reason. The tests use .new rather than .allocate which it could very well do.
The test also has a lot of duplication, where the actual object could be stored and reused.
My suggestion is go ahead and work up a pull request. It will exhibit your thoughts even more completely than a paragraph of words.
Worst thing that can happen is people talk about it and it doesn't get accepted.
from ruby.
StevenXL
commented on June 10, 2024
Thanks @kotp. I'm still new to this whole thing - forgive the lack of links.
I'll do as you suggested and work up a pull request and move the conversation there. Thanks!
from ruby.
Related Issues (20)
- Zipper needs a test for .up.up HOT 3
- test is wrong here [triangle] HOT 2
- [tests] Microwave exercise test suite have errors. HOT 6
- 🤖 Sync error for commit 731e26 HOT 3
- Error in boutique_inventory_test.rb HOT 2
- Simple Linked List exercise confusion HOT 4
- Pre-requisite and missing hints for Simple Calculator HOT 4
- stock_for_item method in boutique Inventory challenge HOT 4
- `item_names` in Boutique Inventory challenge HOT 1
- Kindergarten Garden may be harder than defined HOT 4
- [SavingAccounts]: Suggestion: change negative interest rate tests to return positive value HOT 5
- Hacktoberfest 2022 HOT 2
- Binary Search Ruby HOT 3
- TwoBucket - possible error in test suite HOT 4
- Question about function name in "Moviegoer" exercism HOT 2
- Typo in final bird_count test where "whith" should be "with" HOT 2
- Typo in locomotive_engineer instrucions HOT 2
- Locomotive Engineer exercise relies on implicit Ruby behavior HOT 1
- the pythagorean triplet exercise has something wrong with it HOT 1
- Add analyzer for leap HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ruby.