Comments (6)
Git hooks aren't distributed with the repo, but we could certainly have a little script that initializes a git hook with the correct behavior to make it very, very easy to set up.
from ruby.
We can have a tool that sets it up, no problem at all. It would be distributed in bin, executable, versionable, and just do the right thing. On a *n?x system, it can simply set a soft link but on Windows would have to be a copy maneuver.
The Makefile
can even potentially be used for this, if we wanted to go that way rather than a tool in bin
but I think the bin folder is the way to go.
The question that we need to answer is if we want it to be pre-push or post-commit or pre-commit. I am leaning toward pre-push hook, myself.
Locally, I have simply been watching for file system events in the folder and running make
when the file system changes. Easy enough for continuous testing. I think doing the checks per commit are just a little bit too soon, and a pre-push will give a 'last chance' stage.
from ruby.
Current solution is a copy, should work on Windows. I prefer a soft link, but it may not work well with Windows.
The difference may only affect how maintenance of the hook is done.
from ruby.
I think the bin folder is the way to go.
Yeah, I agree.
The question that we need to answer is if we want it to be pre-push or post-commit or pre-commit.
I think pre-push is fine, so long as people are happy to rebase/squash/edit etc. I was initially leaning towards pre-commit, but the folks who will flail with their commits (who I think pre-commit would help) would probably not set up the hook in the first place, so we'd end up helping them squash etc in the PR anyway.
Current solution is a copy
I think that's fine.
from ruby.
Ready to fall into place for anyone that wants to use it.
from ruby.
Nice!
from ruby.
Related Issues (20)
- Website reporting failure when it should not for custom tests. HOT 5
- Bowling: missing test HOT 1
- Ruby Basics Introduction.md typo HOT 4
- Savings account HOT 13
- `boutique-inventory`: mistake in `introduction.md` for the exercise and `about.md` for the concept
- Zipper needs a test for .up.up HOT 3
- test is wrong here [triangle] HOT 2
- [tests] Microwave exercise test suite have errors. HOT 6
- 🤖 Sync error for commit 731e26 HOT 3
- Error in boutique_inventory_test.rb HOT 2
- Simple Linked List exercise confusion HOT 4
- Pre-requisite and missing hints for Simple Calculator HOT 4
- stock_for_item method in boutique Inventory challenge HOT 4
- `item_names` in Boutique Inventory challenge HOT 1
- Kindergarten Garden may be harder than defined HOT 4
- [SavingAccounts]: Suggestion: change negative interest rate tests to return positive value HOT 5
- Hacktoberfest 2022 HOT 2
- Binary Search Ruby HOT 3
- TwoBucket - possible error in test suite HOT 4
- Question about function name in "Moviegoer" exercism HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ruby.