Giter VIP home page Giter VIP logo

Comments (6)

kytrinyx avatar kytrinyx commented on June 18, 2024

Git hooks aren't distributed with the repo, but we could certainly have a little script that initializes a git hook with the correct behavior to make it very, very easy to set up.

from ruby.

kotp avatar kotp commented on June 18, 2024

We can have a tool that sets it up, no problem at all. It would be distributed in bin, executable, versionable, and just do the right thing. On a *n?x system, it can simply set a soft link but on Windows would have to be a copy maneuver.

The Makefile can even potentially be used for this, if we wanted to go that way rather than a tool in bin but I think the bin folder is the way to go.

The question that we need to answer is if we want it to be pre-push or post-commit or pre-commit. I am leaning toward pre-push hook, myself.

Locally, I have simply been watching for file system events in the folder and running make when the file system changes. Easy enough for continuous testing. I think doing the checks per commit are just a little bit too soon, and a pre-push will give a 'last chance' stage.

from ruby.

kotp avatar kotp commented on June 18, 2024

Current solution is a copy, should work on Windows. I prefer a soft link, but it may not work well with Windows.

The difference may only affect how maintenance of the hook is done.

from ruby.

kytrinyx avatar kytrinyx commented on June 18, 2024

I think the bin folder is the way to go.

Yeah, I agree.

The question that we need to answer is if we want it to be pre-push or post-commit or pre-commit.

I think pre-push is fine, so long as people are happy to rebase/squash/edit etc. I was initially leaning towards pre-commit, but the folks who will flail with their commits (who I think pre-commit would help) would probably not set up the hook in the first place, so we'd end up helping them squash etc in the PR anyway.

Current solution is a copy

I think that's fine.

from ruby.

kotp avatar kotp commented on June 18, 2024

Ready to fall into place for anyone that wants to use it.

from ruby.

kytrinyx avatar kytrinyx commented on June 18, 2024

Nice!

from ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.