Terminal-link usage about eas-cli HOT 5 CLOSED

the problem

terminal-link's isSupported property is true for some terminals (eg: "terminator") where it is not indeed supported. the result is that the user will see some underlined text, but not have any way of actually clicking the link. this is a bad experience. but should we lower the ceiling for the quality of experience in order to accommodate the worst case scenarios?

possible solutions

• upstream improvements to isSupported
• use a wrapper like this one from expo-cli and default to using the fallback on windows and linux (where we're more likely to run into unsupported terminals)
• possibly make exceptions to the previous rule if we can easily detect that a terminal will definitely support terminal-link
• add an env var that users can set to override the default - EXPO_USE_TERMINAL_LINK=1 will always trust terminal-link's isSupported property, and EXPO_USE_TERMINAL_LINK=0 will always use the fallback

from eas-cli.

1. it's not a problem with isSupported itself, doc of terminal-link also list terminator as supported
2. it's probably the easiest solution, instead of checking based on platform maybe we could just whitelist specific terminals we are sure that they work
3. as in point 2
4. env could be useful for debuginng during development if everything looks correct on unsupported terminals, but for users, it wouldn't be a good experience, those links are usually linking to docs or fyi page, so we need to make sure they are alwayss acessible

from eas-cli.

Whitelisting known-good terminals might be the most reliable.

I've run into this issue before with tmux in iTerm2 on a Mac. As far as I remember the problem in my case was that tmux didn't support the feature.

from eas-cli.

This issue is stale because it has been open for 30 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

from eas-cli.

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.

from eas-cli.