Giter VIP home page Giter VIP logo

Comments (2)

nfriedly avatar nfriedly commented on June 9, 2024 1

Hi @oneEyedSunday

I think a combination of skipFailedRequests and a custom requestWasSuccessful would work for you:

const rateLimitByTimeInSecFn = (timeSec, bucketSize, keySuffix = undefined) => rateLimit({
  windowMs: timeSec * 1000,
  max: bucketSize,
  // all requests initially counts against the quota, but then 422 ones are un-counted
  skipFailedRequests: true,
  // We want to only skip 422s - everything else counts against the quota
  requestWasSuccessful: (req, res) => {
    return ![StatusCodes.UNPROCESSABLE_ENTITY].includes(res.statusCode);
  },
  // Default to IP address
  // Or force the same key
  // if provided, use, else default
  keyGenerator: keySuffix ? () => keySuffix : undefined,
  store: new RedisStore({
    passIfNotConnected: true, // If Redis is not connected, let the request succeed as failover
    // see https://github.com/wyattjoh/rate-limit-redis#examples
    sendCommand: (...args) => redisClient.call(...args),
    prefix: `rate-limit-time:${timeSec}sec:`,
  }),
});

The limiter basically has to run before the request if there is any chance that it needs to block it. The skipSuccessfulRequests and skipFailedRequests options both initially count the request against the quota and block it if the user is over their quota, but after the request is completed they then un-count if the conditions are meant.

from express-rate-limit.

oneEyedSunday avatar oneEyedSunday commented on June 9, 2024 1

Hello, thanks for the reply @nfriedly
This should work very well.

from express-rate-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.