Comments (2)
I think a combination of skipFailedRequests
and a custom requestWasSuccessful
would work for you:
const rateLimitByTimeInSecFn = (timeSec, bucketSize, keySuffix = undefined) => rateLimit({
windowMs: timeSec * 1000,
max: bucketSize,
// all requests initially counts against the quota, but then 422 ones are un-counted
skipFailedRequests: true,
// We want to only skip 422s - everything else counts against the quota
requestWasSuccessful: (req, res) => {
return ![StatusCodes.UNPROCESSABLE_ENTITY].includes(res.statusCode);
},
// Default to IP address
// Or force the same key
// if provided, use, else default
keyGenerator: keySuffix ? () => keySuffix : undefined,
store: new RedisStore({
passIfNotConnected: true, // If Redis is not connected, let the request succeed as failover
// see https://github.com/wyattjoh/rate-limit-redis#examples
sendCommand: (...args) => redisClient.call(...args),
prefix: `rate-limit-time:${timeSec}sec:`,
}),
});
The limiter basically has to run before the request if there is any chance that it needs to block it. The skipSuccessfulRequests and skipFailedRequests options both initially count the request against the quota and block it if the user is over their quota, but after the request is completed they then un-count if the conditions are meant.
from express-rate-limit.
Hello, thanks for the reply @nfriedly
This should work very well.
from express-rate-limit.
Related Issues (20)
- Not callable expression in 6.7.1 HOT 14
- Multiple rate limits with different window sizes not working properly HOT 6
- ValidationError: The 'X-Forwarded-For' header is set but the Express HOT 2
- I found that this library occasionally works and occasionally doesn't work. HOT 3
- limit is not working , still need to set max HOT 5
- [Question] keyGenerator option HOT 4
- Get Remaining Rate-Limit HOT 3
- ERR_ERL_DOUBLE_COUNT with multiple rate limits HOT 2
- It blocks all IPs instead of blocking each IP HOT 7
- getKey is undefined in Redis Store HOT 9
- Passed options in RateLimitRequestHandler HOT 1
- Install a problem in express5 / express@next HOT 9
- Can't get the correct ip HOT 3
- Ratelimit headers empty while running on Bun v1.0.x HOT 1
- Don't know how to resetKey when user complete captcha HOT 6
- requestWasSuccessful usage doesn't support returning a Promise
- Can't use process.env variables HOT 3
- Add Support for Persistent Storage (e.g., Redis) in express-rate-limit HOT 1
- Enhanced Rate Limiting with a retryAfter option and IP Blocking Features for Improved Flexibility HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express-rate-limit.