Comments (8)
rajivnarayana
commented on April 28, 2024
1
Will give this a try and submit a PR. It will fix an outstanding bug in one of our projects.
Would like to maintain this plugin!
from express-paginate.
niftylettuce
commented on April 28, 2024
@IchiNiNiIchi does this resolve your issue? http://stackoverflow.com/a/39689389
from express-paginate.
IchiNiNiIchi
commented on April 28, 2024
@niftylettuce thank you for your reply. My question is the result include a "page 0" when I call paginate.getArrayPages(3, 2, 2). Finally I get around this by changing
var start = (currentPage < (limit - 1)) ? 1 : (end - limit) + 1;
to
var start = (currentPage <= (limit - 1)) ? 1 : (end - limit) + 1;
in
Line 72 in a34a719
but I don't know does the change works for other input.
from express-paginate.
rajivnarayana
commented on April 28, 2024
This is still an issue. Changing the code in local copy cannot be a solution. Please reopen this bug.
@niftylettuce , SO Link does not fix anything.
from express-paginate.
niftylettuce
commented on April 28, 2024
@rajivnarayana I reopened the issue - just saw this now
from express-paginate.
niftylettuce
commented on April 28, 2024
feel free to submit a PR! I don't use Express as much as Koa anymore - would you like to help maintain?
from express-paginate.
niftylettuce
commented on April 28, 2024
Great @rajivnarayana! Once your code is in ping me and I will release a new version. When I'm comfortable I'll add you as an NPM owner!
from express-paginate.
rajivnarayana
commented on April 28, 2024
Thanks @niftylettuce for merging v0.3.0. This issue should now be fixed and could be closed.
from express-paginate.
Related Issues (20)
- Infinite scroll HOT 1
- Example with EJS HOT 8
- implement "promises bluebird" HOT 2
- Error: express-paginate: `limit` is not a number >= 0 HOT 1
- Documentation example errors HOT 2
- Update documentation HOT 1
- Page URLs wrong after the first page HOT 1
- Change references from jade to pug HOT 3
- How would I go about using this with mustache HOT 1
- How to send "skip" parameter? HOT 2
- Paginate only show first page HOT 2
- RethinkDB HOT 2
- how to set first and last link? HOT 2
- Handlebars paginate.href true gives weird value HOT 1
- Incompatibility with express 5 HOT 3
- Check integer HOT 1
- Wrong Offset
- Allow specifying minLimit
- @expressjs/triagers lack ability to add labels in express-paginate HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express-paginate.