Comments (11)
This is officially completed! Express.js is back to the CITGM! 🎉
from express.
Yes, I fixed that a long time ago, also in this repo too, which is probably why you cannot reproduce it while running tests locally from clone?
from express.
Curent status
We are just waiting for this PR to be merged, the CI is passing 🥳
from express.
Great point @dougwilson. Now I am thinking that maybe is because CITGM is using 4.18.2
and the patch in [email protected]
is not yet released within express? 🤔
unreleased
==========
* Fix routing requests without method
* deps: [email protected]
- Fix strict json error message on Node.js 19+
- deps: content-type@~1.0.5
- deps: [email protected]
4.18.2 / 2022-10-08
===================
* Fix regression routing a large stack in a single route
* deps: [email protected]
- deps: [email protected]
- perf: remove unnecessary object clone
* deps: [email protected]
from express.
Oh, interesting. I guess that is true, if citgm uses published vereion it wouldn't be there. I was confused bc I saw the log saying downloading from github.com. I guess we can queue up a parch release quickly to make it available to citgm, without going through the minor release timeline.
from express.
Yeah, a patch release sounds great 👍
from express.
Could we maybe do a release as a group on video? One of the things we're gonna need to get better at is training people and how to do these things safely and with the correct procedure. This seems like a good one to get started with.
from express.
Oh, ok, good thing you mentioned! I wqs gonna try and squeeze it in today so we could get the citgm checked off, but I can hold off for us to find a time and day to do it together.
from express.
Obviously we want to land the 5 release soonish, but other than that do we have anything pending to use as an example to record for educational purposes?
from express.
This was just to make a patch for 4 for citgm to use. Happy to do whatever. I have to leave in about 45 mins, and was on to do this patch before the work week starts and I get more limited, but happy to di whatever we want, just let me know. I'll keep holding until I hear more.
from express.
To circle back, there was not time today to finish the CICD and also record this release. We will try and get a recording in a future release, so going to mark my comments and the rest as off topic. Sorry for delaying it.
from express.
Related Issues (20)
- [deleted] HOT 3
- Request triager role for @SarthakParikh HOT 1
- Working On Vite+React. Have an Issue. HOT 1
- 4.19.0 breaks passing new URL() into res.redirect(...) HOT 7
- The npm latest version of express is 5.0.0-beta.2 !!! HOT 10
- Troubleshooting Node.js Express Server Routing Issue HOT 1
- mime.charsets in Response.js is undefined HOT 8
- WebAssembly Out of memory Error for any server HOT 2
- return res.redirect('back'); returns to '/' instead of the previous page HOT 2
- Need a clarification on router.param() usage. HOT 4
- [Question] Should Express.js v5.x drop support to older versions of Node? HOT 3
- .get() attempting to grab from home dir (Linux) HOT 2
- Request triager role for Ivaylo-Iv HOT 1
- Request triager role for etroynov HOT 2
- clean code for switch condition HOT 2
- Response location broken for unicode domains in latest release HOT 1
- help typing Request query with object
- Using colon as a character instead of path parameter (express 5) HOT 1
- Support HTTP `QUERY` method HOT 3
- Nominating @carpasse to the triage team HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express.