Giter VIP home page Giter VIP logo

Comments (4)

Ajido avatar Ajido commented on May 4, 2024

I also tried to fix the 'write after end' as below. Thoughts?

+exports.stream
+
 exports = module.exports = function morgan(format, options) {
   if (typeof format === 'object') {
     options = format
@@ -56,12 +58,12 @@
   var fmt = compile(exports[format] || format || exports.default)

   // options
-  var stream = options.stream || process.stdout
+  exports.stream = options.stream || process.stdout
     , buffer = options.buffer;

   // buffering support
   if (buffer) {
-    var realStream = stream
+    var realStream = exports.stream
     var buf = []
     var timer = null
     var interval = 'number' == typeof buffer
@@ -79,7 +81,7 @@
     }

     // swap the stream
-    stream = {
+    exports.stream = {
       write: function(str){
         if (timer === null) {
           timer = setTimeout(flush, interval)
@@ -99,7 +101,7 @@
       if (skip(req, res)) return;
       var line = fmt(exports, req, res);
       if (null == line) return;
-      stream.write(line + '\n');
+      exports.stream.write(line + '\n');

from morgan.

dougwilson avatar dougwilson commented on May 4, 2024

No, I want to stop having globals on the export.

The answer is you cannot close the write stream until you stop accepting requests on your http server (i.e. wait for server.close to callback).

from morgan.

PizzaBrandon avatar PizzaBrandon commented on May 4, 2024

As a side thought, if you cannot close the write stream until you stop accepting requests, how would one go about implementing daily log file rotation? It doesn't seem practical to shut down your server every night at a specified time just so you could start a new log file.

from morgan.

dougwilson avatar dougwilson commented on May 4, 2024

For log rotation, the stream itself would implement that. You can find file rotation streams on npm like https://www.npmjs.org/package/rotate-file-stream

from morgan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.