Comments (4)
I also tried to fix the 'write after end' as below. Thoughts?
+exports.stream
+
exports = module.exports = function morgan(format, options) {
if (typeof format === 'object') {
options = format
@@ -56,12 +58,12 @@
var fmt = compile(exports[format] || format || exports.default)
// options
- var stream = options.stream || process.stdout
+ exports.stream = options.stream || process.stdout
, buffer = options.buffer;
// buffering support
if (buffer) {
- var realStream = stream
+ var realStream = exports.stream
var buf = []
var timer = null
var interval = 'number' == typeof buffer
@@ -79,7 +81,7 @@
}
// swap the stream
- stream = {
+ exports.stream = {
write: function(str){
if (timer === null) {
timer = setTimeout(flush, interval)
@@ -99,7 +101,7 @@
if (skip(req, res)) return;
var line = fmt(exports, req, res);
if (null == line) return;
- stream.write(line + '\n');
+ exports.stream.write(line + '\n');
from morgan.
No, I want to stop having globals on the export.
The answer is you cannot close the write stream until you stop accepting requests on your http server (i.e. wait for server.close to callback).
from morgan.
As a side thought, if you cannot close the write stream until you stop accepting requests, how would one go about implementing daily log file rotation? It doesn't seem practical to shut down your server every night at a specified time just so you could start a new log file.
from morgan.
For log rotation, the stream itself would implement that. You can find file rotation streams on npm like https://www.npmjs.org/package/rotate-file-stream
from morgan.
Related Issues (20)
- Error: EBADF: bad file descriptor, write HOT 7
- Is there a way to get the start time instead of the finish time?
- Custom tokens returning function string HOT 1
- Is this compatible with angular 11? HOT 1
- Usage in ES6 promise based import does not work HOT 1
- skip function not working with 'immediate:true' configuration HOT 3
- Colored status token HOT 1
- Dexter Morgan HOT 2
- Use morgan as custom console logger HOT 3
- morgan block my auth login redirection when I use createWriteStream for stream option HOT 9
- Adding a token named token causes all subsequent tokens to break. HOT 3
- req.route.path value is undefined HOT 3
- :res[content-length] only shows size less than 1 KB HOT 2
- Support for promise HOT 2
- Getting vulnerable issue [email protected] HOT 1
- Expose `stream.write` as option HOT 2
- webscoket request should be logged HOT 2
- SPDY > Express.JS > Next.JS don't show path details.
- `User: ':remote-user'` does not show logged-in user but `-`
- Issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from morgan.