Giter VIP home page Giter VIP logo

Comments (6)

dougwilson avatar dougwilson commented on May 5, 2024 3

Technically this module does not allow you to do this, because it's entire purpose is to write one standard access.log line per request, but technically you can hack this together, based on #24 (comment) :

// Define your morgan logger to log JSON to your client
// The object here takes your keys and strings that use
// the morgan token format
app.use(logger(format({
  response_time: ':response-time',
  remote_addr: ':remote-addr',
  remote_user: ':remote-user',
  status: ':status',
  url: ':url',
  // etc.; any non-standard tokens you would have to implement
})));

function format(obj) {
  var keys = Object.keys(obj)
  var token = /^:([-\w]{2,})(?:\[([^\]]+)\])?$/
  return function (tokens, req, res) {
    var data = {}
    for (var i = 0; i < keys.length; i++) {
      var val = token.exec(obj[key])
      data[key] = val !== null
        ? tokens[val[1]](req, res, val[2])
        : obj[key]
    }
    console.log(JSON.stringify(data, null, 4))
  }
}

from morgan.

nodesocket avatar nodesocket commented on May 5, 2024

Trying:

    app.use(morgan(rethinkdbLog({
        id: ':id',
        date: ':date[iso]',
        http_version: ':http-version',
        method: ':method',
        url: ':url',
        status: ':status',
        response_time: ':response-time',
        remote_user: ':remote-user',
        remote_addr: ':remote-addr',
        user_agent: ':user-agent',
        referrer: ':referrer'
    })));

    function rethinkdbLog(obj) {
        var keys = Object.keys(obj);
        var token = /^:([-\w]{2,})(?:\[([^\]]+)\])?$/;

        return function (tokens, req, res) {
            var data = {};
            for (var i = 0; i < keys.length; i++) {
                var val = token.exec(obj[key]);
                data[key] = val !== null ? tokens[val[1]](req, res, val[2]) : obj[key];
            }

            r.table('requests').insert(data, { returnChanges: true }).run(rethinkdbConnection, function(error, result) {
                if(error) {
                    handleError(res, error);
                }
                else if (result.inserted !== 1) {
                    handleError(res, new Error("Failed to insert request log document into RethinkDB."));
                } else {
                    next();
                }
            });
        };
    }

Getting:

                var val = token.exec(obj[key]);
                                         ^
ReferenceError: key is not defined

from morgan.

dougwilson avatar dougwilson commented on May 5, 2024

Oops, my bad. You need to add

var key = keys[i]

as the first line in the for loop.

from morgan.

nodesocket avatar nodesocket commented on May 5, 2024

Thanks worked great. One thing I noticed is that the field response_time comes back as a string instead of a number. Is this intentional?

{ id: 'c1dabb4e-03c3-4ec3-a127-b11a0b3f936a',
  date: '2015-05-31T21:49:18.687Z',
  http_version: '1.1',
  method: 'GET',
  url: '/',
  status: 200,
  response_time: '10.509',
  remote_user: '-',
  remote_addr: '::ffff:127.0.0.1',
  user_agent: 'curl/7.37.1' }

from morgan.

dougwilson avatar dougwilson commented on May 5, 2024

Because this module is intended for writing log lines, yes, all tokens come back as strings--you would have to add Number() or parseFloat() to your code if you wanted them as numbers.

from morgan.

dougwilson avatar dougwilson commented on May 5, 2024

Yes, status code is coming back as a number, I know. If you wanted to know the main reason response time comes back as a string, it's because the response time can be 0ms, as as a number, 0 is falsy, but as a string, '0' is truthy, so 0 doesn't get translated to -.

from morgan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.