Giter VIP home page Giter VIP logo

Comments (3)

dougwilson avatar dougwilson commented on May 4, 2024

Interesting. Sadly this is how mogran has operated since it was first written: 7962211 which means at least right now, it's a documentation issue (where the docs are just wrong).

We cannot actually change the timing of the firing without releasing a major (which is restricted until August).

The fix doesn't require behavior to be altered (i.e. the timing of the log writing does not need to be altered), and I'll try to get to it this weekend if someone doesn't get to it first. It boils down to tracking the event properly and storing the value somewhere; a fix really needs to happen to the :date token as well.

from morgan.

STRML avatar STRML commented on May 4, 2024

How about a new token, like response-time-internal? It would get around the major release issue. I think that both numbers are useful.

from morgan.

dougwilson avatar dougwilson commented on May 4, 2024

The major version bump was in reference to changing the timing of the log firing :) The actual fix for this can be done with a minor to be safe (but really could be a patch version, technically).

from morgan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.