Giter VIP home page Giter VIP logo

Comments (10)

dougwilson avatar dougwilson commented on May 18, 2024

Sure, though can you provide more information on how SVG works for the favicons?

  1. Are they still served under /favicon.ico?
  2. What MIME type do they usually use?
  3. Which browsers support this?

from serve-favicon.

defunctzombie avatar defunctzombie commented on May 18, 2024

I don't think anyone supports this. Crisp definition on retina requires a special retina ready favicon (actually two favicons in one file). This library already supports that use case.

from serve-favicon.

dougwilson avatar dougwilson commented on May 18, 2024

Besides that, this library is just for the /favicon.ico-style implicit icons; the SVG stuff doesn't even do that and requires the used to add HTML anyway, so it seems to be out of the scope of this library.

from serve-favicon.

Fishrock123 avatar Fishrock123 commented on May 18, 2024

There isn't enough support for favicon svgs for it to be worthwhile. it is better to pack multiple resolutions into your .ico.

Tools for this can be difficult to find, however.

A best case ICO has 16, 24, 32, 48px and possibly a 64 px or bigger version.

from serve-favicon.

julesmoretti avatar julesmoretti commented on May 18, 2024

Thank you for your consideration. I appreciate the legacy of using ICO, though I would argue that packing multiple pixel heavy ico (in the case of Fishrock123 - 5 different version), is not as clean as vector information svg that can take on any scale due to its vector base.

As a UX designer, it is far cleaner to use vector files then having to fudge with pixel to try to make things ready... plus if not now, it is going to happen soon enough.

Just a thought...

from serve-favicon.

dougwilson avatar dougwilson commented on May 18, 2024

@julesmoretti I think you mis-understand what this module even does: this module only serves the requests for the standard /favicon.ico URL. There is no standard for a SVG file, so there is nothing for us to support in this library. To use a SVG favicon, you have to add the path to it in your HTML, and at that very point it's outside the scope of this module.

from serve-favicon.

dougwilson avatar dougwilson commented on May 18, 2024

Wikipedia explains this module pretty OK. If you go to https://en.wikipedia.org/wiki/Favicon#How_to_use you can see the many ways to specify a favicon. The "favicon.ico located in the website's root" is the only purpose of this module.

from serve-favicon.

julesmoretti avatar julesmoretti commented on May 18, 2024

@dougwilson ok cool sorry for the bother.

from serve-favicon.

Fishrock123 avatar Fishrock123 commented on May 18, 2024

I'm really not sure any browsers even accept svg favicons at the current time..

from serve-favicon.

dougwilson avatar dougwilson commented on May 18, 2024

I think there may be a couple, but since you have to use a <link> tag, you can just serve them up with all your other files.

from serve-favicon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.