Comments (10)
Sure, though can you provide more information on how SVG works for the favicons?
- Are they still served under
/favicon.ico
? - What MIME type do they usually use?
- Which browsers support this?
from serve-favicon.
I don't think anyone supports this. Crisp definition on retina requires a special retina ready favicon (actually two favicons in one file). This library already supports that use case.
from serve-favicon.
Besides that, this library is just for the /favicon.ico
-style implicit icons; the SVG stuff doesn't even do that and requires the used to add HTML anyway, so it seems to be out of the scope of this library.
from serve-favicon.
There isn't enough support for favicon svgs for it to be worthwhile. it is better to pack multiple resolutions into your .ico
.
Tools for this can be difficult to find, however.
A best case ICO has 16, 24, 32, 48px and possibly a 64 px or bigger version.
from serve-favicon.
Thank you for your consideration. I appreciate the legacy of using ICO, though I would argue that packing multiple pixel heavy ico (in the case of Fishrock123 - 5 different version), is not as clean as vector information svg that can take on any scale due to its vector base.
As a UX designer, it is far cleaner to use vector files then having to fudge with pixel to try to make things ready... plus if not now, it is going to happen soon enough.
Just a thought...
from serve-favicon.
@julesmoretti I think you mis-understand what this module even does: this module only serves the requests for the standard /favicon.ico
URL. There is no standard for a SVG file, so there is nothing for us to support in this library. To use a SVG favicon, you have to add the path to it in your HTML, and at that very point it's outside the scope of this module.
from serve-favicon.
Wikipedia explains this module pretty OK. If you go to https://en.wikipedia.org/wiki/Favicon#How_to_use you can see the many ways to specify a favicon. The "favicon.ico located in the website's root" is the only purpose of this module.
from serve-favicon.
@dougwilson ok cool sorry for the bother.
from serve-favicon.
I'm really not sure any browsers even accept svg favicons at the current time..
from serve-favicon.
I think there may be a couple, but since you have to use a <link>
tag, you can just serve them up with all your other files.
from serve-favicon.
Related Issues (20)
- Purpose HOT 3
- Performance HOT 2
- where do i get the favicon icon ? HOT 1
- Support Requirement for Multiple Favicons HOT 4
- doc typo HOT 1
- serving different favicon for different pages HOT 1
- If no favicon present, should just return a 404 HOT 13
- Possible to use location outside of your repo? HOT 4
- Can't see favicon when using Microsoft Edge HOT 2
- Vary favicon by domain HOT 4
- Doubts on res._headers HOT 3
- Favicon not showing when running server with long context path. HOT 5
- How to use png favicon files? HOT 1
- how can I use a url instead of path? HOT 4
- how to add different favicon for different routers? HOT 3
- serve-favicon vulnerable to RegEx Denial of Service attack HOT 1
- Favicon is not showing HOT 5
- Can't run express js server app on my local host:3000 HOT 4
- Feature Request: Serve icon based on host mapping HOT 2
- Doesn't work with Chrome HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serve-favicon.