Comments (3)
You're correct. The CSS rules end up within the <def>
section of the SVG just as they are in your CSS rules, which means that if you have a selector for a parent element of the SVG, none of your CSS rules will be applied within the SVG.
You're not doing anything wrong. This is just a scenario I hadn't personally run into, but is a perfectly reasonable one.
Pruning a prefix from any CSS selectors would probably only fix a subset of the problem. Also, it's awkward to have to work out CSS rules and selector prefixes.
One way to address this would be to apply the styling rules directly to the elements in the SVG before the node is cloned. However, I don't like mutating the original SVG. Also, it would re-introduce Element.querySelectAll
, which means it wouldn't handle selectors like [ng:name]
.
I'll have to think about how to handle this. Suggestions are welcome.
from savesvgaspng.
I agree, the "cleanest" way would be to apply the styling rules directly. I think you can traverse the rules, check if they apply to the original element, then add them to the cloned element/children in-line (reintroducing querySelectAll
and its issues unfortunately).
It's quite the hassle though and probably not worth the effort if no one else is running into this problem =)
In case anyone else is interested, I'm applying this "quick and dirty" hack before outer.appendChild(clone)
:
// Traverse through the ancestors of the element, stopping before the body, and append the class
var curr = el;
while (curr = curr.parentElement) {
if (curr.tagName == "body") break;
// classList might have to be polyfilled in certain browsers (http://stackoverflow.com/a/14101453)
for (var i = 0; i < curr.classList.length; i++) {
clone.classList.add(curr.classList[i]);
}
}
But this is really a cheat, working only because I ultimately use SVG elements as the last element in my CSS selectors (e.g. rect
, text
, line
, etc.).
from savesvgaspng.
I've added a hook for rewriting CSS selectors. The third argument of saveSvgAsPng
should now be an options object, and if a CSS rule matches within the SVG being exported, it will call the selectorRemap
function and use the returned selector instead of the one specified in the original stylesheet.
An example:
saveSvgAsPng(document.getElementById('test'), 'test.png', {
selectorRemap: function(s) {return s.replace('#svg-id', '')}
});
This rewrites CSS rules such as #svg-id circle
to just circle
.
It's not as automatic as I might like, but it's versatile. Let me know if it doesn't solve your problem.
from savesvgaspng.
Related Issues (20)
- when <svg> has <img>,con't show the imge in the png HOT 3
- Size of downloaded image varying according to the zoom level of browser HOT 1
- Only half of the SVG is rendered
- saveSvgAsPng without css styleSheets, modifyCss dosen`t work, who can tell me how to use modifyCss HOT 3
- saveSvgAsPng makes svg's image fill disappear (d3.js) HOT 9
- use to generate PNG on server? (solved: using sharp.js instead) HOT 2
- CSS rule breaks export? HOT 3
- i get this error ReferenceError: excludeUnusedCss is not defined HOT 1
- How to add a Google Font? HOT 3
- Uncaught (in promise) TypeError: Cannot read property 'width' of undefined at saveSvgAsPng.js:265 HOT 1
- ReferenceError: navigator is not defined (using Node.js) HOT 1
- How to use fonts in options parameter. HOT 3
- saveSvgAsPng is not capturing all the items inside svg tag
- HOW can i do, if the dataURl size > 2M
- some svgs not working on mobile safari
- Syntax error HOT 1
- svgAsPngUri working on browser but not android HOT 1
- Add/Update TypeScript type definitions
- HTMLElement or SVGElement in Chrome HOT 1
- problem with Canvg library
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from savesvgaspng.