Giter VIP home page Giter VIP logo

Comments (10)

fabian-hiller avatar fabian-hiller commented on September 23, 2024 1

Thank you!

from valibot.

ruiaraujo012 avatar ruiaraujo012 commented on September 23, 2024 1

I can see that. I'm OK with checkItems, so go on :D.

from valibot.

ruiaraujo012 avatar ruiaraujo012 commented on September 23, 2024 1

Thank you. I saw you have created more Items actions, which is nice :)

from valibot.

fabian-hiller avatar fabian-hiller commented on September 23, 2024

I have started to work in this issue.

from valibot.

ruiaraujo012 avatar ruiaraujo012 commented on September 23, 2024

Nice, thanks for letting me know.

from valibot.

fabian-hiller avatar fabian-hiller commented on September 23, 2024

I am still unsure of the correct name. The advantage and difference of this action is that a issue is automatically associated with the item that caused the problem. items and iterate do not reflect this in my eyes. What do you think about checkItem or forEach? The name checkItem is very clear and easy to read. forEach might also work as I plan to add actions for the other iterator methods like sort and filter as well.

from valibot.

fabian-hiller avatar fabian-hiller commented on September 23, 2024

I ran into another problem. Since we already have a map schema, I can't add a map action for transforming arrays due to the name collision. One solution to this problem is to call the map action forEach. Another solution might be to add the suffix Item or Items to these functions: everyItem, filterItems, findItem, mapItems, reduceItems, someItem. The last solution would also work well with checkItems.

from valibot.

ruiaraujo012 avatar ruiaraujo012 commented on September 23, 2024

What about checkEach? I think it reflects what it does. checkItems it's a good name as well.
I agree with you when you say that items or iterate doesn't reflect what it does.

from valibot.

fabian-hiller avatar fabian-hiller commented on September 23, 2024

checkEach is great, but I really like the Item and Items suffixes for the iterator actions. This makes it even clearer and prevents other naming conflicts in the future. If we go this way, checkItems would make more sense in my eyes.

from valibot.

fabian-hiller avatar fabian-hiller commented on September 23, 2024

Valibot v0.33.1 is now available 🎉

from valibot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.