Giter VIP home page Giter VIP logo

Comments (6)

IlyaSemenov avatar IlyaSemenov commented on September 27, 2024 1

Thank you for the reply. Anyhow, this issue is fully resolved so I'm closing it.

from valibot.

fabian-hiller avatar fabian-hiller commented on September 27, 2024

Instead of a string, you can also pass a function to any schema and validation action to dynamically generate the error message. The first argument of this function gives you access to the issue object. Also, I will soon start working on a refine action (issue #597) that will give you full control for such advanced cases.

const Schema = v.string((issue) => `Expected: ${issue.expected}`);

from valibot.

IlyaSemenov avatar IlyaSemenov commented on September 27, 2024

Thanks you for the heads up. However, this way of dynamically generating messages is quite limited. What I mean is, arguably, more often than not these dynamic messages will be based on validation context. In my example above, the message depends on extracted characters. This way, I basically need to repeat the logic twice, first in check and then in the message generator.

In my real life use case, I am validating a textarea value which is supposed to store the whitespace delimited list of wallets where each wallet must be a valid base58-encoded public key. The validation is supposed to report the particular malformed string, or which keys are duplicate, or when it's not enough or too many of them and why — all and all, that are mostly context-dependent messages.

I hope refine will make this possible!

from valibot.

fabian-hiller avatar fabian-hiller commented on September 27, 2024

Please have a look if rawCheck solves this issue for you: #597 (comment)

from valibot.

IlyaSemenov avatar IlyaSemenov commented on September 27, 2024

It does:

const schema = v.pipe(v.string(), v.rawCheck(({ dataset, addIssue }) => {
  if (dataset.typed) {
    const [c1, c2, c3] = dataset.value
    if (c1 === "f" && c2 !== c3) {
      addIssue({ message: `Since the first letter is "${c1}", the second and third letters ("${c2}" and "${c3}") should equal.` })
    }
  }
}))

I'm still not really following why do we need the obligatory if (dataset.typed) boilerplate in each and every check, but at least it gets things done, thank you.

from valibot.

fabian-hiller avatar fabian-hiller commented on September 27, 2024

It does

I think I was able to simplify your scheme. However, your version is probably a bit more readable.

import * as v from 'valibot';

const Schema = v.pipe(
  v.string(),
  v.check(
    ([c1, c2, c3]) => c1 !== 'f' || c2 == c3,
    ({ input: [c1, c2, c3] }) =>
      `Since the first letter is "${c1}", the second and third letters ("${c2}" and "${c3}") should equal.`,
  ),
);

I'm still not really following why do we need the obligatory if (dataset.typed) boilerplate in each and every check, but at least it gets things done, thank you.

This is because I am working on validation actions that allow you to validate untyped data if the part of the data you want to validate is typed. This is really important for form validation. Without this functionality, we can't show errors that depend on multiple fields if any other field is untyped.

from valibot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.