Giter VIP home page Giter VIP logo

Comments (5)

fabianmichael avatar fabianmichael commented on May 24, 2024

By source files, do you means the originals inside of the content folder?

What optimizers are activated in you config file?

Regarding the linked piece of code: When testing optimizers, I realised that sometimes the resulting »optimized« version of a file is bigger than the input file. Some optimizers can handle that and only override a file, when the optimization was able to reduce file size. But some don’t offer this ability, so I decided to check this in PHP.

from kirby-imagekit.

bnomei avatar bnomei commented on May 24, 2024

yes. it deletes one JPG image file out of the content folder for each time i try to call imagekits widget. it seems to crash after the first image once the original (content folder file) gets removed (which it should not ever).

c::set('imagekit.optimize', true);
c::set('imagekit.gifsicle.bin', 'PATH/gifsicle-linux');
c::set('imagekit.jpegtran.bin', 'PATH/jpegtran-linux');
c::set('imagekit.optipng.bin',  'PATH/optipng-linux');
c::set('imagekit.pngquant.bin', 'PATH/pngquant-linux');

from kirby-imagekit.

bnomei avatar bnomei commented on May 24, 2024

it seems it has nothing to do with optimizers after all. if the colorthief lib gets caught in a execution timeout the file process gets removed. yes, thats imageset actually not imagekit – i know.

c::set('imageset.placeholder', 'color');

Error on
plugins/imageset/vendors/ColorThief/Image/Adapter/ImagickImageAdapter.php on line: 85

from kirby-imagekit.

fabianmichael avatar fabianmichael commented on May 24, 2024

Okay, I had a more in-depth look at the code and added an additional check before calling ColorThief.

I’ve created a new branch for that in the ImageSet repo, please check if it now works for you, because I could not replicate your error: https://github.com/fabianmichael/kirby-imageset/tree/source-images-deleted-error

Thanks for your help!

from kirby-imagekit.

bnomei avatar bnomei commented on May 24, 2024

I could not replicate my error it with this new tree. Thanks!

from kirby-imagekit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.