Giter VIP home page Giter VIP logo

Comments (13)

fabiensanglard avatar fabiensanglard commented on August 13, 2024

Can you tell me what is the output of the command

which inskcape

Also what OS are you using?

from gebbdoom.

 avatar commented on August 13, 2024
$ which inkscape
/usr/bin/inkscape

This is on Arch Linux.

from gebbdoom.

fabiensanglard avatar fabiensanglard commented on August 13, 2024

That is the path used in make.sh. What is the exact error message you are getting?

from gebbdoom.

 avatar commented on August 13, 2024

Hi,

when I run make.sh, there is no error message. So I edited the make.sh to remove output redirect:

-               inkscape $exportOption="$dst" --without-gui --export-dpi=100 "$src" > /dev/null 2>&1
+               inkscape $exportOption="$dst" --without-gui --export-dpi=100 "$src"

So then it outputs stuff like this:

$ ./make.sh
    Pango version: 1.48.2
Convert screenshots_svg/3do_motherboard.svg to PNG (100dpi).
Warning: Option --without-gui= is deprecated
Unbekannte Option --export-file=/home/fs/git/gebbdoom/src/screenshots/3do_motherboard.png
Convert screenshots_svg/3do_vectors.svg to PNG (100dpi).
Warning: Option --without-gui= is deprecated
Unbekannte Option --export-file=/home/fs/git/gebbdoom/src/screenshots/3do_vectors.png
Convert screenshots_svg/486_layout.svg to PNG (100dpi).
Warning: Option --without-gui= is deprecated
Unbekannte Option --export-file=/home/fs/git/gebbdoom/src/screenshots/486_layout.png

with Unbekannte Option being unknown option.

Changing the inkscape command to the one given in the initial post works without a problem with my version of Inkscape.

Hope that helps a bit.

from gebbdoom.

 avatar commented on August 13, 2024

That is the path used in make.sh. What is the exact error message you are getting?

Not sure I understand this remark. In the make.sh here there is no path used at all. It's just running plain inkscake here, so looking it up in the $PATH environment variable. Or am I missing something?

from gebbdoom.

fabiensanglard avatar fabiensanglard commented on August 13, 2024

The script attempts to detect what version of inkscape is available and then uses either --export-file or --export-png. In your case it seems the outcome of this line

[[ $(inkscape --version | awk -F '[ .]' '{ print $2 }') -gt 0 ]] && exportOption="--export-file" || exportOption="--export-png"

If not doing what is expected.

What value does the following command returns

inkscape --version | awk -F '[ .]' '{ print $2 }'

from gebbdoom.

deluxe avatar deluxe commented on August 13, 2024

Inkscape seems to have deprecated command --export-file since 1.0rc1.
--export-file should be replaced by --export-filename indeed.

--without-gui is an old option, already deprecated in 0.92. It can be removed without impact.

from gebbdoom.

fabiensanglard avatar fabiensanglard commented on August 13, 2024

Probably no the right thing to support older versions of inkscape. If we do, make.sh will become a mess.

The fix would be to request a minimum version of inkscape in make.sh, fail if it is not there, and use the appropriate flags.

from gebbdoom.

deluxe avatar deluxe commented on August 13, 2024

Dropping support for older versions of Inkscape is sensible in the long run. Now fixing this precise bug doesn't require adding any mess to make.sh. See for yourself:

  1. Updating options and keeping the support (for now): deluxe@a5ff5b7
  2. Checking version and cutting support: deluxe@8a21e04

from gebbdoom.

fabiensanglard avatar fabiensanglard commented on August 13, 2024

#1 Maybe trigger older version of Inkscape to start the GUI doesn't it?
#2 Looks like the way to go.

from gebbdoom.

 avatar commented on August 13, 2024
$ inkscape --version | awk -F '[ .]' '{ print $2 }'
    Pango version: 1.48.2
1

from gebbdoom.

deluxe avatar deluxe commented on August 13, 2024
  1. does not trigger GUI on version 0.92.x of Inkscape but may indeed trigger GUI on even older versions.
  2. cut the support clearly.

I'll test 2. on Linux and make you a Pull Request.

from gebbdoom.

deluxe avatar deluxe commented on August 13, 2024

Fixed by #32.

from gebbdoom.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.