Giter VIP home page Giter VIP logo

Comments (6)

AngelMunoz avatar AngelMunoz commented on June 14, 2024

Can you share how are you using the component?

LitElement.init must be called on top of the render function this error if I recall correctly only happens if you don't call it in the top of your LitElement decorated function so if we could see how you were using it on your first example it would be nice

Also I would test this in the final build mode because I'm not sure it is supported

from fable.lit.

juselius avatar juselius commented on June 14, 2024

Here is how I use it:

[<LitElement("ol-map")>]
let OlMap ()  =
    Hook.useHmr hmr
    let this, props =
        LitElement.init (fun cfg ->
            cfg.useShadowDom <- true
            cfg.props <-
                {|
                    map = Prop.Of(Map.map [], attribute = "map")
                |}
            cfg.styles <- [
                css $"{olCss}"
                // unsafeCSS olCss
                css $"""
                  .map {{
                    width: 100%%;
                    height: 80vh;
                    background: #a2e7ff;
                  }}"""
            ])
    Hook.useEffect (fun () ->
        if isNull this.shadowRoot |> not then
            let target = getShadowElementById this "map"
            props.map.Value.setTarget target
    )
    html $"""<div id="map" class="map"></div>"""

When you say final build mode, you mean the output of fable --run vite build?

from fable.lit.

alfonsogarciacaro avatar alfonsogarciacaro commented on June 14, 2024

Lit has a restriction that styles must be statically declared with the css tagged template (so they can be analyzed and ensure they don't contain malicious code): https://lit.dev/docs/components/styles/#expressions

image

The error is misleading, it seems we're missing a Promise.catch here to show the actual error:

config.InitPromise
|> Promise.iter (fun _ ->

from fable.lit.

juselius avatar juselius commented on June 14, 2024

What is then the correct way of getting a css package into a (shadowed) component? I'm interfacing OpenLayers to Fable (I'll release the package in due time), and OpenLayers comes with a bunch of css, and it would be nice (but not strictly necessary) to contain it in the Lit component.

from fable.lit.

AngelMunoz avatar AngelMunoz commented on June 14, 2024

One thing that the shadow DOM has is that it was not designed to work with global styles so this tends to create a lot of friction when you try to integrate with third party style libraries.

The simplest and fastest workaround would be to just not use shadow DOM if you depend heavily on third party css or while not optimal but doable you can add a style/link tag inside your shadow DOM component and it should work properly

but for completeness the ideal thing though would be to use css import assertions
please note that while css assertions are already on the spec it is only supported in chrome and thus needs a polyfill

// please note that Fable doesn't have an out of the box
// way to import css/json assertions so you need to create 
// cssImport manually somehow
let styles: obj = cssImport "dependency.css"
// inside the config function
cfg.styles <- [ css $".my-local-style {{ display: flex }}"; unbox styles]

That being said I made a project which hasn't been updated in a while that covers this use case it's called Fable.ShadowStyles and you can see me hacking my way around thanks to vite here and using them here

from fable.lit.

juselius avatar juselius commented on June 14, 2024

Thank you for your suggestions @AngelMunoz!

from fable.lit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.