Flaw in generic mapping about intermediary HOT 6 CLOSED

Not done, see discussion in #2

from intermediary.

An internal Stitch branch now performs bridge lookup.

The question is: Should this change be introduced on the 19w update? Does it have the potential to break any existing mod?

from intermediary.

If you take the simplest example of calling the methods:

Serializer testA = new Serializer();
testA.read(new Identifier(""), new JsonObject());
testA.method_8142(new Identifier(""), new JsonObject());

The first call will get obfuscated back to the interface's name (method_8121) whilst the second will keep it's naming. Thus the second direct call would break but the first abstract one would be fine.

This is only a problem if the concrete types have been used too:

RecipeSerializer<ShapelessRecipe> testB = new Serializer();
testB.read(new Identifier(""), new JsonObject());

Would get obfuscated to method_8121 and thus would carry on working fine. It is most likely people have been using the abstract methods as the concrete ones appear to lack any non-Intermediary names.

As for actually extending the types, due to the clunky naming Java already doesn't see them as actually implementing the interfaces:

public class Test extends Serializer {

	@Override
	public ShapelessRecipe read(Identifier var1, JsonObject var2) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public ShapelessRecipe read(Identifier var1, PacketByteBuf var2) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public void write(PacketByteBuf var1, ShapelessRecipe var2) {
		// TODO Auto-generated method stub

	}

Is what you get when Eclipse automatically fills the missing methods, ie the interface's names with the proper generic signatures. The generated bridges override correctly too, so the only issue people would have is if they called the concrete methods directly rather than using the interface's abstract methods.

from intermediary.

I think its best to stall this for the first 19w update, or hopefully an 18w50b (though unlikely).

from intermediary.

FabricMC/stitch@2e001d7

Implemented. Awaiting snapshot.

from intermediary.

Wow this hasn't been touched since 2018 lol

from intermediary.