Comments (1)
I think this seems like a fine improvement. Right now buck.type comes from some internal data that probably can't be changed (as it's used to lookup the rule impl function during analysis), but I don't see any reason why we couldn't just store a separate user-configurable (with current default) field on rules. We could even call it "kind" and then buck.kind would use it (and the kind()
query function could match against it) and maybe we could then get buck.type to be back to the fully-qualified symbol (it used to be this, but to match buck1 behavior we switched it to just the local name of the symbol).
from buck2.
Related Issues (20)
- Distributed project.ignore
- How to use c/aquery to find the dependents of an anon_target HOT 7
- Trouble linking Apple Frameworks HOT 1
- documentation mentions `frecli` which doesn't seem to be available publicly HOT 1
- Adding support for new languages HOT 5
- Java rules don't appear to be usable in OSS edition of buck2 HOT 4
- Builtin prelude support for running python in a venv? HOT 1
- `actions.write_json` does not propagate dependencies HOT 4
- Cyclic computation error with `dynamic_output`
- `zip_file` prelude rule partially exported HOT 2
- export_exe isn't documented on buck2.build
- `expand-external-cell` fails when using inotify watcher HOT 3
- fstring support HOT 2
- buck-out directory as cachedir HOT 3
- feature: "top-level-types required" mode for `.bzl` files HOT 7
- Feature: act as Make job server when executing locally
- Recommendations for making hermetic runnables?
- Best way to define a pure Runnable from a command line? HOT 1
- Documentation on toolchains is lacking HOT 2
- Documentation on labels is lacking
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buck2.