Comments (15)
I have a proof of concept of this working: https://twitter.com/dan_abramov/status/773799004878565376.
I’d like #419 to land first, and then I can add this.
from create-react-app.
I agree we should print the terminal output in an overlay if the compilation fails.
@glenjamin worked on https://github.com/glenjamin/webpack-hot-middleware that does this, but IIRC it had some other problems.
So I’d like to see this as a feature, but probably implemented as a custom client instead of the one that ships with WebpackDevServer.
from create-react-app.
I'd happily accept any PRs / specific fixes for problems in hot-middleware, it already has a custom HMR client and is widely used.
You are of course free to port/fork, but it'd be good to share if possible.
from create-react-app.
Could you make it not depend on polyfill in IE? As I recall this was the biggest issue.
from create-react-app.
(Not saying it’s the only one tho. If you could make a PR porting from WDS to the middleware it would be easier to find other issues.)
from create-react-app.
One thing I love about Brunch is that in case of error it will show a system notification, no config required. :w
and seeing an error notification, it's easier to go to another terminal tab and see the stack trace, than to cmd+tab to the browser after saving a few files only to then spot an error.
from create-react-app.
Sounds interesting. Perhaps we should do that. Want to take a stab at PR?
from create-react-app.
There even seems to be a webpack plugin for that already https://www.npmjs.com/package/webpack-error-notification
from create-react-app.
Which doesn't work on Windows, though.
Sure, I'll take a stab at it tomorrow!
from create-react-app.
The options for this are either plain WebSocket, which is IE10+ or a lib that magically deals with fallbacks - which would be weightier.
Any thoughts on what is preferable?
On 22 Jul 2016, at 20:31, Dan Abramov [email protected] wrote:
Could you make it not depend on polyfill in IE? As I recall this was the biggest issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
from create-react-app.
What was the motivation behind not using WebSockets?
from create-react-app.
Ironically I thought it'd be simpler & more reliable!
On 22 Jul 2016, at 23:17, Dan Abramov [email protected] wrote:
What was the motivation behind not using WebSockets?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
from create-react-app.
(Submitted #131 to add notifications)
from create-react-app.
#419 landed :)
from create-react-app.
I was just looking into it. 😄
from create-react-app.
Related Issues (20)
- Create react app HOT 1
- login issue
- my sign in not working
- HMR not working
- [email protected]
- "npx create-react-app" doesn't generate src or public folders HOT 1
- Usage override/workaround/hack with ESLint 9
- Frontend Host doesn't match the current host in the browser, so it's probably incorrect. Links in emails and file downloads from the API will not work. Click here to update. HOT 1
- [https://newsroom.spotify.com/news/](https://deezer.page.link/fCBsxrTRUZvKbLkA8) HOT 3
- react-scripts/v/5.1.0-next.14 contains multiple security vulnerabilities for inner modules
- Issue in creating react app HOT 4
- cra打包路由切换FiberRootNode会新增,webpack打包就不会 HOT 1
- Error -4048 and Error -4058 and ENOENT, HOT 1
- Des erreurs apres installation de mui sur un projet React 18.0.0 ou supérieur HOT 1
- del proyecto
- how i can run react program in vs code HOT 4
- React JS HOT 4
- @babel/plugin-proposal-private-property-in-object missing from babel-preset-react-app dependencies
- Npx create-react-app: 8 vulnerabilities (2 moderate, 6 high) in new react app HOT 1
- 不动 啊
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-react-app.