Comments (9)
@Aerion got it. let me do some preparations to help on this. I might not have bandwidth on checking the correctness but I could publish 1) the codegen lib 2) csharp mustache template very soon.
from facebook-business-sdk-codegen.
Hello, thanks a lot for the feedback and sharing this PR!
Indeed it needs a bit of tweaking, I'll take it from here. And we are definitely interested in the C# portion, thanks for this too!
from facebook-business-sdk-codegen.
Gentle ping, any chance of getting the repository back on track ? :)
from facebook-business-sdk-codegen.
@PHBourquin we're aware of this issue and working on a mitigation. may i ask if you are debugging the codegen procedure from spec to per language code? what is the use case here?
from facebook-business-sdk-codegen.
Thanks for your quick response!
what is the use case here?
We would be interested in trying out adding support for another language (C#), instead of having to maintain our own Meta API client, which requires manual change at each Meta API version upgrade.
working on a mitigation
If you have any procedure, even if it requires to do multiple steps or hacks, we'd really appreciate if you could share it, as we'd like to dedicate some effort to implement this new client on our side.
from facebook-business-sdk-codegen.
@Aerion thank you so much for sharing this information. I noticed that there were previously some csharp related work that is halfway done. I could try to post this portion of codebase out so that we could resume it and later to create a separate repo for csharp support. Will this be something you are interested in?
from facebook-business-sdk-codegen.
Will this be something you are interested in?
Definitely!
For the context, we're having some kind of hackathon right now, and we have the coming days available for where we were hoping to do the C# client, and according to the results, propose our work as a PR.
We weren't expecting the build issue. Our thought process was to:
- Build this repo locally, to confirm that we can generate the clients of other languages locally
- Then start with a csharp folder and have a simple GET of a route working
- Iterate over the implementation until we have something working
By ourselves, we're stuck on the first step, so if there is some structure already with csharp support, we'd be interested in it.
On the other hand, having the procedure to build the existing clients would also unlock us, as we'd be able to start on the csharp support too.
To recap, we're open to anything that would enable us to advance on the csharp support :)
from facebook-business-sdk-codegen.
@Aerion could you locally patch this PR #80 i believe this contains something that hopefully could help you. basically right now babel
is broken but you could still generate via codegen script.
from facebook-business-sdk-codegen.
Small update on the topic FYI, making good progress with https://github.com/PHBourquin/facebook-business-sdk-codegen/tree/csharp-draft with a basic implementation for C# clients.
As we move toward a clean PR, I'd like to have your opinion on how should we proceed regarding the current state of the repository with babel & lib/ files, as they are affected by my changes. If we can get back the repository to a clean "default" state to push C# implem on top of it 🙂
In the meantime, feel free to have a glance at the C# implem itself if you are curious!
from facebook-business-sdk-codegen.
Related Issues (13)
- Feature Request: Ads Library API
- FacebookAds\Object\AdAccount -> createAdCreative() not handling the exception properly.
- Missing Call-to-Action enum CALL_NOW HOT 1
- Cannot run CodeGenerator.js HOT 2
- Feature Request: Add missing types for nested Objects (such as Ads/insights/filtering)
- Creation of AdSet suffers from breaking changes HOT 1
- CodeGenerator for python:v14 seems broken
- targeting_optimization_types has wrong type HOT 2
- How can I auto-generate types for a new API version? HOT 2
- Ad Account Users Endpoints Removed HOT 1
- SDK Codegen patches are not working as expected ? HOT 1
- Cannot build due to `src/ doesn't exist` issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from facebook-business-sdk-codegen.