How to reject client request with ERR_FILE_NOT_FOUND? about fbtftp HOT 4 CLOSED

Hey sorry for the late response, I was off for the holidays. :-)

So you could use get_response_data and throw any exception in your implementation. The Exception will be caught and a ERR_UNDEFINED error will be returned to the client as you see here:

https://github.com/facebook/fbtftp/blob/master/fbtftp/base_handler.py#L145

That is supposing that returning ERR_UNDEFINED is ok for you.

from fbtftp.

One better way could be to define a new GetResponseDataException that carries a message string together with a TFTP error code constant as defined in https://github.com/facebook/fbtftp/blob/master/fbtftp/constants.py#L21

from fbtftp.

if you decide to go with the latter proposal we are more than happy to review your PR!!! :)

from fbtftp.

I am closing this "issue". Please feel free to reopen if you need more clarifications and as I already said feel free to send us a PR if you want to implement the last thing I suggested :)

from fbtftp.