Comments (7)
@lnicco Thanks for the fix! Confirmed it fixes the issue, much appreciated!
from proxygen.
To clarify, I can build the libs if I set -DBUILD_SAMPLES=OFF
. So it seems the issue is mainly with the sample code?
from proxygen.
thanks for reporting this issue @timsutton.
I tried to reproduce locally on MacOS 14.2 but the build completes correctly.
Did you have any luck reproducing locally? That would help us understand the issue and work on a fix
from proxygen.
Just to confirm is your repro on an Apple Silicon machine?
I can repro it locally (on AS) within the same context that a brew build is done, via a brew install --build-from-source proxygen
on a branch that bumps these various shared libraries, like this one. I think the basic instructions to recreate it would be (assuming gh
CLI is installed):
brew tap homebrew/core
cd $(brew --prefix)/Library/Taps/homebrew/homebrew-core
gh pr checkout 160044
export HOMEBREW_NO_INSTALL_FROM_API=1
# (I might have some of the deps orderings wrong here, this is to ensure they're all built via brew from the same 2024.01.15 revision)
brew install -s mvfst
brew install -s folly fizz wangle
brew install -s proxygen
# ^ should fail, you can add the --debug to give the option to drop into a shell in the proper build env, when it errors
Separately I just tried to see about doing a local build from the repo directly and leaving homebrew out of it, but when I ran build.sh
from the proxygen I hit a snag during the Folly build: https://gist.github.com/timsutton/514f2ddc79337dc212f533fb4a690352
If I wanted to try setting up the build differently (as CI does) I could try and follow through the GitHub actions flow here. It looks like the CI uses macOS 12 with Xcode 14.2. Haven't yet tried that though.
from proxygen.
I was able to figure out which commit broke it
1a9557d
I am however still working on reproducing the build error locally (on a macbook air M2 on Sonoma 14.2.1)
I hit a snag during the Folly build:
Yeah this seems to be an issue with the build.sh script that is somehow picking up the homebrew version (v10) of the fmt library instead of the one that it installs itself (v9).
Can you try brew uninstall --ignore-dependencies fmt
and rerun build.sh?
from proxygen.
I was able to repro and will land a fix soon.
from proxygen.
please reopen if the patch doesn't fix the issue
from proxygen.
Related Issues (20)
- HTTP3 Server and Client from samples HOT 11
- Does proxygen support iOS ?
- Transferring Sessions between threads for Http Client Connection Pool HOT 8
- DetachThreadLocals() fails CHECK HOT 22
- ServerIdleSessionConroller:getIdleSession() returns session already in thread HOT 5
- Concurrent performance supported by the HTTP server
- Websocket Key Mismatch HOT 2
- Connection Close Reason SHUTDOWN HOT 3
- `EchoHandler` in `proxygen/httpserver/samples/echo/EchoHandler.h` has unnecessary `body_` member
- Request smuggling vulnerability in Proxygen
- websocket client with SSL problem: Server replied to me "Bad Request" HOT 5
- proxygen fails to build when a newer glog package is installed
- Proxygen for iOS HOT 2
- httpserver/samples/websocket
- Ingress Error and drain() HOT 2
- httpserver/samples/websocket
- Segfault in HQ server
- Build problems, segfault UT HOT 2
- Remove the use of requiring sudo for installing deps HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proxygen.