HTTP2 Protocol Error about proxygen HOT 3 CLOSED

Found the cause of the issue, and it was that the Proxygen is sending END_STREAM Flag separately in a empty DATA Frame, instead it can send it with the HEADERS Frame itself. Modified it to send END_STREAM Flag within the HEADERS Frame and the issue got resolved.

from proxygen.

Can you share a snippet of your code fix?

There's definitely some friction in proxies because the onHeadersComplete codec callback doesn't include the END_STREAM flag, so it can be challenging to immediately pass through to an upstream without making an assumption (eg: GET == END_STREAM) or delaying an event loop so the onEOM downstream callback fires.

I've even tried fixing this once, but ran into some complications.

from proxygen.

I don't know whether this approach is right or not. But somehow it works for now.

HTTP2Codec.cpp
Line No:520

if (!(curHeader_.flags & http2::END_STREAM)) {
  // If it there are DATA frames coming, consider it chunked
  msg->setIsChunked(true);
}

This code tells that if the stream ends or not. If it doesn't end the HTTPMessage is set to chunked.
So in ProxyHandler, I am checking whether the CodecProtocol is HTTP2 and HTTPMessage is not chunked, if both conditions satisfy, then sending the Upstream transaction with EOM using sendHeadersWithEOM().

ProxyHandler.cpp

if (txn_->getTransport().getHTTPSessionBase()->getCodecProtocol() == proxygen::CodecProtocol::HTTP_2 && 
downstream_->getTransaction()->getTransport().getHTTPSessionBase()->getCodecProtocol() == proxygen::CodecProtocol::HTTP_2 &&
 !request_->getIsChunked()) {
    txn_->sendHeadersWithEOM(*request_);
}
else {
    txn_->sendHeaders(*request_);
}

This code checks whether both Upstream and Downstream works in HTTP2 and then checks whether the message is chunked which in turn is true if END_STREAM is not set.

Please provide some insights on whether this approach is right or not.

from proxygen.