Giter VIP home page Giter VIP logo

Comments (5)

nmn avatar nmn commented on July 26, 2024 2

This is a valid issue. You can suppress the ESLint error for now.

from stylex.

nmn avatar nmn commented on July 26, 2024 1

@necolas My bad. I assumed it was a bug in the Babel plugin because it used to be a bug at one point. You're right, the best solution here is to just suppress the ESLint error.

from stylex.

necolas avatar necolas commented on July 26, 2024

Surely the better workaround is to ignore the eslint-plugin's warning? Isn't the correct syntax the one in the OP, not the one in the workaround above? I think pseudo-elements shouldn't be allowed within property object-values - that doesn't really make sense to me.

The role of the eslint-plugin should be limited to stylistic things like "sort keys", or other opinionated preferences like "don't use px values for font-size", not for validating syntax or allowed properties.

from stylex.

nedjulius avatar nedjulius commented on July 26, 2024

should this be removed from the plugin?

if (level > 0 && propName == null) {

there is a TODO comment that reminds to remove this suggestion as well

from stylex.

nmn avatar nmn commented on July 26, 2024

should this be removed from the plugin?

With some extra checks to disallow it for anything but pseudo elements.

from stylex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.