Comments (3)
@matrinox could you clarify what you mean by this, and what performance costs you observe?
from fixed-data-table.
@ehzhang This is what you need to do to reproduce:
- Render component with
<Table
rowGetter={@rowGetter}
…
/>
- in
rowGetter
function, log the rowIndex/first param:console.log(rowIndex)
- scroll to the top of the list and then keep scrolling
Notice that the logs keep coming even though clearly no rows have changed. In fact, I feel like it shouldn't bother calling that method unless a new row is really needed, as opposed to just on ever scroll. Performance cost isn't that high but could be better. It should only call it once when the user scrolls 1 pixel past the next row, versus all of them again.
from fixed-data-table.
Hmm! I just checked it out, and it looks like you're right - there are duplicate calls to the rowGetter function. However, if you add logs to a cellRenderer function, you'll notice that the cells themselves don't actually re-render.
The performance of the rowGetter is negligible, as the real bottleneck here is rendering. I've decided to close this issue as it is more of a micro-optimization.
from fixed-data-table.
Related Issues (20)
- Doesn't work to modify css
- hovered row after scrolling by mouse wheel
- The README Basic example does not work HOT 3
- Performance on iPad 3rd Gen Tablet
- v0.6.0 - unable to receive `row` argument in `onRowClick` callback
- Cannot add property xxxxxx, object is not extensible
- Warning: FixedDataTable: isMounted is deprecated. HOT 16
- How to render multiple rows at the footer
- How to get Current displaying row numbers HOT 1
- Basic Example not working
- How to truncate extra-long text with ellipses?
- Deprecate this project HOT 6
- Sluggish scrolling when accessibility is enabled on Android
- Need examples as part of this with Huge Export Options For Reference
- Can I get current row index using onScrollStart/onScrollEnd ? HOT 2
- Update license to MIT in order to align with React. HOT 4
- Import Functions
- expanded row Height remains fixed
- Scrolling horizontally using gestures causes browser to navigate through history instead of scrolling the table.
- normalizeWheel too fast in Windows firefox
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fixed-data-table.