Comments (9)
Maybe rather than cleaning up the dependencies, use multi step build (2nd FROM and COPY) and just copy over binaries and install runtime dependencies? This way you don't need to do any cleanups, which might be error-prone (as the issue).
from logdevice.
I'd have to sing CLA I guess, which seems to be too much hassle :)
I'd split ubuntu.deps into build deps and runtime deps and then follow https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#use-multi-stage-builds
from logdevice.
@MohamedBassem has passed his work-in progress changes over to me, I'll be picking this up next
from logdevice.
Update taking @MohamedBassem 's work forward; I now have a work in progress branch on my fork:
https://github.com/calebmarchent/LogDevice/tree/multistep_docker_ubuntu
This builds a docker image that can run the LogDevice cluster; image size: 340MB.
Next I'll add in more components to get all the tools working and do some testing.
from logdevice.
Yes, I can confirm we have been a little overzealous in clean-up of Dockerfile, having completed the build.
from logdevice.
That sounds like a good strategy @mateusz-gozdek-sociomantic. Would you like to send a PR to address that?
from logdevice.
@MohamedBassem are you going to send a PR for this or should we close that one?
from logdevice.
I have published a pull request: #23
from logdevice.
PR #23 is now merged; closing issue
from logdevice.
Related Issues (20)
- Inconsistent column type for node_id in Sequencer and Nodes table HOT 3
- Settings abort-on-failed-check, abort-on-failed-catch and external-loglevel don't correctly subscribe to settings update HOT 1
- Tests failed in master due to some folly singletons being used without calling folly init
- Make DSCP reflection configurable in server settings HOT 1
- ModuleNotFoundError: No Module named 'libfb' HOT 1
- LogDevice build failing on Ubuntu bionic HOT 4
- logdevice/build_tools/fedora.deps file doesn't exist HOT 2
- With latest code, linking integration_test fail with SIGSEGV
- The log range specified must be positive 62-bit with start smaller or equal than end of range, supplied range is 0..200000 HOT 3
- Can not build on Ubuntu 19.10 HOT 3
- Will sequencer become a bottleneck for large size record with high throughput HOT 4
- Replication policy cross multiple cities with one special deferred? HOT 4
- Can not build on Ubuntu 18.04.4 HOT 2
- Conditional add question HOT 2
- Run quickstart through docker image failed HOT 1
- I want to integrate Kubernetes with VirtualLog. HOT 1
- Docker build fbthrift compilation thrift/lib/py3/test/gen-py3/testing/clients.cpp failed
- Is this project no longer maintained? HOT 12
- [email protected]
- LogDevice cluster start error --- NOSEQUENCER and sequencer:[invalid NodeID]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logdevice.