Comments (6)
Yes, this issue is mentioned on the wiki:
https://github.com/facebook/pfff/wiki/Spatch#spacing-issues
You can avoid the issue by rewriting the patch as
X
- =
- =&
$this->Application->recallObject(Y1, Y2, Y3);
from pfff.
@aryx , can you please use fenced code blocks, because GitHub has formatted your suggestion as Markdown and I get what was changed.
Also I'm not sure, but using (...)
doesn't work and error is displayed. Because of that I hard to create 2 patches: one for mandatory arguments and one for mandatory + optional arguments.
from pfff.
I've tried rewriting patch like so:
-X = $this->Application->recallObject(Y1, Y2, Y3)
+X =&
$this->Application->recallObject(Y1, Y2, Y3)
but I'm getting an error:
Fatal error: exception Failure("could not parse: X = $this->Application->recallObject(Y1, Y2, Y3)\n\n$this->Application->recallObject(Y1, Y2, Y3)\n")
from pfff.
The following patch:
-X
+X =&
$this->Application->recallObject(Y1, Y2, Y3)
gives this error:
Fatal error: exception Failure("could not parse: X\n\n $this->Application->recallObject(Y1, Y2, Y3)\n")
from pfff.
X
- =
+ =&
$this->Application->recallObject(Y1, Y2, Y3);
from pfff.
Thanks, that worked perfectly.
I'm not sure why, but following was also done (spaces after comma in list(...)
construct):
list(
- $product_id, $backorder, $qty, $price, , , , $order_item_id, $options_salt, $item_data, $cost
+ $product_id, $backorder, $qty, $price,,,, $order_item_id, $options_salt, $item_data, $cost
) = $operation_row;
from pfff.
Related Issues (20)
- failed to build on MacOSX 10.10 on file 'utils_js.cmi' HOT 1
- scheck complains about "No such file or directory" for php files being tested HOT 1
- make fails on mac OS X Yosemite HOT 3
- Codegraph unknown option -lang HOT 2
- Issue compiling within Homebrew formula HOT 2
- [sgrep] Support for parseable reports HOT 2
- zlibstubs.c:171:33: error: use of undeclared identifier 'uint32' HOT 8
- Trying to build on macOS 10.12 HOT 2
- OSX Yosemite 10.10.5 + make error HOT 5
- OSX Yosemite 10.10.5 + make error - php_vs_php.cmo HOT 2
- Error while running codegraph on Mac OS X 10.11.3 HOT 2
- No support for local variable in `codegraph`?
- OPAM installation failed HOT 1
- Fatal error: exception Failure("php checker needs a graph file") - Mac Sierra HOT 8
- How command pfff output store in a file? HOT 2
- codegraph -lang java -build "path/to/source/code" error
- Can't build on Mac HOT 7
- [spatch] Replacing "||" doesn't work
- Fatal error: exception Common.Todo HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pfff.