Comments (4)
Hey @axemclion,
You're right that in many cases (excluding Edge and Safari), stringify-then-post is faster than posting a POJO. I've been intending to clean up some of the bridge code to do exactly this, as well as some explicit measurement of time spent across the bridge. Mostly, the code is the way it is right now because some of it is yanked from RN, some of it was written to add some of our needs, and in general we've been pushing for functionality over perf until we reach the full public release. But thanks for bringing this up! I believe stringifying the body will bring some real perf improvements.
from react-360.
Thanks for the response !! I have been playing with React Web-Worker Performance for a while and have recently started diving into react-vr, primarily because of the web-worker design.
Is the perf work you are doing available somewhere to take a look at ?
I am using the infamous DBMonster as a perf benchmark. Will report back on any findings I have. Some other related questions
- Is there a better performance benchmark application that I should instead use ? I am looking to write an automated performance monitor
- The react-vr-web project is not yet open sourced, and I simply pulled out
node_modules/react-vr-web
and am modifying that. Is that a good starting point ? - I see that the operations currently are added to a queue, and then processed during every requestAnimation frame. Is that set in stone, or would exploring alternatives there make sense ?
from react-360.
Looks like we don't need JSON.stirngify
hacks anymore - https://bugs.chromium.org/p/chromium/issues/detail?id=148757#c165
from react-360.
If someone is looking for help I have created simple module that makes communication between "Web Worker" and "Main Thread" easy :)
https://github.com/venits/react-vr-bridge
from react-360.
Related Issues (20)
- How to read cursor position
- react 360 is not working in windows whlie using node.12.14.1 and react16.3.1 HOT 4
- How to add a simple static button over react-360?
- how can I exactly create 360 video with react 360? HOT 1
- I can use the device camera as background with React-360?
- Creating a gitter or discord server for the open source contributors.
- how to run the dev server on windows ?
- Is it possible to make an effect as if a viewer is moving around the space? HOT 1
- Maintained? HOT 9
- Environment.setBackground gives an error
- It's possible to pass `-h` as a folder name
- starting issue HOT 4
- React-360 Camera Movement on Mobile Devices HOT 1
- render pano image by layers
- If you're going to revoke patents, at least remove it from the README HOT 1
- Can we add popup window to screenspace instead of world space? HOT 1
- Using document object or jquery inside react 360 component HOT 1
- Model animations load and play
- unable to run react vr http://localhost:8081/vr/ HOT 3
- React360 is incompatible with Oculus Quest HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-360.