Giter VIP home page Giter VIP logo

Comments (2)

aditi-pandit avatar aditi-pandit commented on June 30, 2024

@pramodsatya : I tried to repro this with the following code

TEST_F(AggregateWindowTest, fuzzerTestFailure) {
  auto c0 = makeFlatVector<int64_t>({1, 1, 1, 1, 1, 1, 1, 1, 1, 1});
  std::vector<int64_t> c1Vector = {
    116046945367747275, 158974630665072867, 2244875474122244932,
    3148654803738462351, 3550897651387022177, 5105548653791430694,
    5842560344486019605, 6279807244011096880, 6461315255634262331,
    7717907586427583831 };
  std::vector<int64_t> c1rangeVector;
  c1rangeVector.reserve(10);
  for (auto c1 : c1Vector) {
    std::cout << c1 - 2364390614705783022 << "\n";
    c1rangeVector.push_back(c1 - 2364390614705783022);
  }

  auto c1 = makeFlatVector<int64_t>(c1Vector);
  auto c2 = makeFlatVector<int64_t>(c1rangeVector);
  auto c3 = makeFlatVector<double>(
      { 0.687331699533388, 0.8206623792648315, 0.8206623792648315,
       0.2248822799883783, 0.9166490170173347, 0.38860476203262806,
       0.38860476203262806, 0.8206623792648315, 0.10044080135412514,
       0.9166490170173347 });
  auto input = makeRowVector({c0, c1, c2, c3});

  auto c4 = makeNullableFlatVector<double>(
      {std::nullopt, std::nullopt, std::nullopt, 1.5079940787982196,
       1.5079940787982196, 2.328656458063051, 2.5535387380514294,
       3.470187755068764, 3.470187755068764, 3.858792517101392});
  auto expected = makeRowVector({c0, c1, c2, c3, c4});
  WindowTestBase::testWindowFunction(
      {input},
      "sum(c3)",
      "partition by c0 order by c1 asc nulls last",
      "range between unbounded preceding and c2 preceding",
      expected);
}

This generates the k-range value column as

-2248343669338035747
-2205415984040710155
-119515140583538090
784264189032679329
1186507036681239155
2741158039085647672
3478169729780236583
3915416629305313858
4096924640928479309
5353516971721800809

and gets the correct results.

So I'm unsure of the values printed in the k1 column. Can you give more information if possible ?

from velox.

pramodsatya avatar pramodsatya commented on June 30, 2024

Looks like the k1 column was generated incorrectly and the issue is resolved now, thanks for pointing it out @aditi-pandit.

from velox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.