Giter VIP home page Giter VIP logo

Comments (5)

michaelbrundage avatar michaelbrundage commented on July 24, 2024

Thanks for reporting this. I've fixed this in f6d9d94. pip doesn't have a way for us to keep pip install kats the default and allow users to optionally opt-out of some functionality; only the opposite. So, to get a reduced version of Kats without Pytorch, plotly, and many other packages (everything listed in test_requirements.txt), you can now use

MINIMAL=1 pip install .

from the root level of the Kats source, and in the future (after we release the next version of Kats),

MINIMAL=1 pip install kats

If you later decide you want some of those additional functionalities, you can manually install the ones you want, or install all of them with

pip install -r test_requirements.txt

from kats.

meakbiyik avatar meakbiyik commented on July 24, 2024

@michaelbrundage thanks for the quick resolve. One question though: why not poetry? I thought it was becoming kind of an industry standard by now, and you can add both the optional tag to packages, and also bundle them with extras flexibly. Also since it is PEP 517 compliant, the whole previous pipeline with pip will continue to work.

An example from a package I have written: the CLI component is optional, so those packages are marked as optional and can be installed by specifying the cli extra during install (or after install): pip install [blah] -E cli .

from kats.

michaelbrundage avatar michaelbrundage commented on July 24, 2024

@meakbiyik The goal was to remove dependencies, not add a new one. However, PRs always welcome. Kats would need a pyproject.toml first, and need to install smoothly across all platforms we support.

from kats.

adamantike avatar adamantike commented on July 24, 2024

@michaelbrundage, for people using this project and installing it within their own requirements.txt file, would you consider having a more specific environment variable, as that would be the only alternative if they want a minimal installation of kats but not of the rest of their dependencies (in case any other one also considers the MINIMAL variable)?

A small change like this one would be everything we need to avoid any undesired side effects on our installation process:

if not os.environ.get("MINIMAL", False) and not os.environ.get("MINIMAL_KATS", False):
    install_requires += extra_requires

from kats.

michaelbrundage avatar michaelbrundage commented on July 24, 2024

Thanks for the PR. Is there any reason to add a second variable, or should we just rename the one variable from MINIMAL to MINIMAL_KATS to avoid potential conflicts with any other projects?

Can you point to any examples of other projects that use the MINIMAL variable?

from kats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.