Giter VIP home page Giter VIP logo

Comments (4)

nikhilaravi avatar nikhilaravi commented on July 17, 2024

@hansen7 thanks for the suggestion! :)

Could share some more details about your proposed implementation for either of the two methods you mentioned above?

Please be aware that for new features to PyTorch3D we require:

  1. CPU and GPU implementations
  2. Comprehensive unit tests and benchmark tests (following the format in the tests folder)
  3. All style checks and unit tests must pass
  4. Any changes to the public API to be discussed first in this issue (i.e please follow the API format from the current sample_points_from_meshes function)

As a first step you can also submit a PR with the PyTorch implementation of one of the methods which we can review. Let us know if you have any questions.

from pytorch3d.

williamljb avatar williamljb commented on July 17, 2024

Hi Nikhila Ravi,

If it is not too complicated, it would be great if the current sampling algorithm can have an option to smooth the normals sampled.

Thank you for the great work!

from pytorch3d.

nikhilaravi avatar nikhilaravi commented on July 17, 2024

@williamljb FYI farthest point sampling is now available in pytorch3d in the main branch on GitHub (not yet in a release):

from pytorch3d.ops import sample_farthest_points

from pytorch3d.

williamljb avatar williamljb commented on July 17, 2024

@williamljb FYI farthest point sampling is now available in pytorch3d in the main branch on GitHub (not yet in a release):

from pytorch3d.ops import sample_farthest_points

Great! Thanks!

from pytorch3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.