Giter VIP home page Giter VIP logo

Comments (6)

WindChimeRan avatar WindChimeRan commented on August 20, 2024

Maybe this is because I used float32? Do I have to use float 16?

from spanbert.

mandarjoshi90 avatar mandarjoshi90 commented on August 20, 2024

That should not make a difference. Sorry about the delay. I'll look into it this week.

from spanbert.

danqi avatar danqi commented on August 20, 2024

@WindChimeRan

Besides replacing that line of code,

Can you post the command that you have run the code and how many epochs/updates did you run and get this F1 score?

I can take a look.

from spanbert.

WindChimeRan avatar WindChimeRan commented on August 20, 2024

Update:

If I put the training evaluation line into https://github.com/facebookresearch/SpanBERT/blob/master/code/run_tacred.py#L498, then it's ok. However, I can still not figure out why my first version failed.

python code/run_tacred.py \
  --do_train \
  --do_eval \
  --data_dir <TACRED_DATA_DIR> \
  --model spanbert-base-cased \
  --train_batch_size 32 \
  --eval_batch_size 32 \
  --learning_rate 2e-5 \
  --num_train_epochs 10 \
  --max_seq_length 128 \
  --output_dir tacred_dir \

I keep all the setting the same with the README.md except for fp16. Yes, fp 16 does not make difference.

The score of spanbert-large on training set is:

Precision (micro): 93.094%
Recall (micro): 96.034%
F1 (micro): 94.541%

from spanbert.

danqi avatar danqi commented on August 20, 2024

I am still confused. Did you pass --eval_test or not? If you are going to change line #498, you have to add --eval_test otherwise it would still use the dev examples.

Do you think this is still an issue or I can close it?

from spanbert.

WindChimeRan avatar WindChimeRan commented on August 20, 2024

#498 is the main change. I also did many minor changes that I cannot remember all of them.

Thanks for your reply.

from spanbert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.