Test get_os and get_package_manager functionality about logoslinuxinstaller HOT 5 CLOSED

Let's make sure the relevant info from these functions is logged during install. Then we can more easily verify if they're working, and which systems have been tested.

from logoslinuxinstaller.

relevant logging output added in PR #40

from logoslinuxinstaller.

Ubuntu

I can confirm that get_os() works correctly for Ubuntu by defining config.OS_NAME as'ubuntu' and config.OS_RELEASE as '20.04'. I don't know about debian, but I'd say it's safe to assume that all Ubuntu derivatives also at least have the OS_RELEASE value right.

get_package_manager() correctly sets config.SUPERUSER_COMMAND and correctly identifies apt as package manager. It looks like config.PACKAGE_MANAGER_COMMAND_QUERY also works, except that it finds all packages that start with the intended package name, not just the package itself. E.g. for Ubuntu and binutils:

$ dpkg -l | grep -E '^.i  'binutils
ii  binutils                                                    2.34-6ubuntu1.7                             amd64        GNU assembler, linker and binary utilities
ii  binutils-common:amd64                                       2.34-6ubuntu1.7                             amd64        Common files for the GNU assembler, linker and binary utilities
ii  binutils-x86-64-linux-gnu                                   2.34-6ubuntu1.7                             amd64        GNU binary utilities, for x86-64-linux-gnu target

In this case binutils is included in the results, so there's no problem. But it also matches binutils-common:amd64 and binutils-x86-64-linux-gnu, which are maybe dependencies of binutils, but they are still additional results that turn up. But still, it's maybe unlikely that a "false positive" will be found without also finding the intended package in the same search.

from logoslinuxinstaller.

From what I can tell, we can drop the following from Arch dependencies:

• curl
• gawk
• bc
• libxml2

Also, there is a duplicate of patch in the current list.

Manjaro's dependencies should be able to drop:

• curl
• gawk
• bc
• libxml2

RHEL should be able to drop:

• libxml2
• curl
• bc

It looks like apt is already set to be pretty bare, but we should probably add grep, wget, sed to the requirements as these are used by the script. And we should probably have libfuse3/fuse3 as a requirement in that line. Originally this was optionally checked if a user was going the AppImage route, but since we aren't doing that, the only thing we could do is append it to the var if the user selects an AppImage, which might be the easiest, but then we'd need to be careful about overwriting that.

These can be dropped because they were used in the Bash script but are no longer thanks to built-in Python libraries.

Also, does anyone remember why we need samba/samba-winbind? Was this something specific to Logos 9?

Further, cabextract (and samba?) should be able to be moved to config.L9PACKAGES, or removed if #53 is pursued.

One question this brings up: since our default/recommended Wine is an AppImage, should wine be a package in config.PACKAGES, as it is in Arch, or optional, as it is in Manjaro?

@jg00dman, is there any reason why wine-staging should definitely be a required package instead of the AppImage for SteamOS?

from logoslinuxinstaller.

Also, I think we will need to separate out the steamOS specific packages. I'm looking at things like qt5-virtualkeyboard and maybe some of the printing things or apparmor. Most of the libraries should be standard for just making sure we can call the proper libraries.

This will require a flag to switch these vars under the elif…pacman of get_package_manager() based on config.OS_NAME.

from logoslinuxinstaller.