Giter VIP home page Giter VIP logo

Comments (52)

thermatk avatar thermatk commented on September 21, 2024 1

Next release should be possible to build in F-Droid. Hooray!

https://gitlab.com/fdroid/fdroiddata/merge_requests/2523/

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024 1

Thank you very much for your help

from tui-consolelauncher.

MichalLebeda avatar MichalLebeda commented on September 21, 2024

Yes, i dont know why open source project is being released on google play.

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

@MichalLebeda Why not?

@AlfaOmega33 Feel free to fix #45 and then it will be build.

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

@licaon-kter could you please help me updating the F-Droid version? It's driving me mad

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

Not my area of expertise, sorry.

from tui-consolelauncher.

lss4 avatar lss4 commented on September 21, 2024

The issue #45 seems solved as I'm able to import the Gradle and build the most recent code with Android Studio. I'm not sure how F-Droid works but now it should in theory be possible to update the F-Droid version.

from tui-consolelauncher.

 avatar commented on September 21, 2024

Just found out about this launcher... I'll wait for that update on F-Droid.

from tui-consolelauncher.

thermatk avatar thermatk commented on September 21, 2024

now there are Google's binary dependencies 😮

from tui-consolelauncher.

lss4 avatar lss4 commented on September 21, 2024

So far the only occurrence of Firebase is in ThemesManager for database purposes. While not offensive, it can further hamper the possibility of a new build on F-Droid as it refuses to build apps using Firebase and other related non-free stuffs.

from tui-consolelauncher.

thermatk avatar thermatk commented on September 21, 2024

I've split into flavors, foss is eligible for F-Droid. Sadly, I just had to delete theme altogether from foss

from tui-consolelauncher.

Bubu avatar Bubu commented on September 21, 2024

Any chance for a new release?

from tui-consolelauncher.

 avatar commented on September 21, 2024

Ah finally, new version is out.

from tui-consolelauncher.

thermatk avatar thermatk commented on September 21, 2024

I just picked the latest commit hash and pushed 😃

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

How?

from tui-consolelauncher.

thermatk avatar thermatk commented on September 21, 2024

@Andre1299 I see 6.5 on Play, but source is at 6.4? Will update to 6.5 when it's out, please push

from tui-consolelauncher.

thermatk avatar thermatk commented on September 21, 2024

https://gitlab.com/fdroid/fdroiddata/merge_requests/3052/
👍

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Could you please tell me how can I update the fdroid repo?

from tui-consolelauncher.

thermatk avatar thermatk commented on September 21, 2024

This is merged, so will be built and updated this week
As there is no consistent release tagging here, only manual updating works

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Where can I manually update?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

@Andre1299 "Manual update" means in the context of metadata used to build it.

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

@licaon-kter I released the version 6.7

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

What are these? https://github.com/fAndreuzzi/TUI-ConsoleLauncher/tree/master/libs

We need sourcecode or libs pulled from approved maven repos for everything included in the app. Binary files can't be used.

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

I replaced them with Gradle dependencies

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

@fAndreuzzi The tag is b0rken, it should be v6.7b

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Is it good now?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

Yes and no, autoupdate won't pick it up since you did not also bump versionName and versionCode. But we can build like this and in the next release you increment them an needed.

FYI, please keep the tag formatting vX.Y and don't mix them eg. 6.8, v6.9 as this confuses the autoupdater. ;)

So, with those two JARs it build fine but now it fails: https://gist.github.com/licaon-kter/424984f1f92b2e29de2035e4f67e14e3

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

I uploaded proguard-rules.pro and drafted a new release. How is it going now?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

Better

FYI, https://gitlab.com/fdroid/fdroiddata/commit/b04e8e5350974ef9b01dade3002736217567e01e

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Thank you very much!

So from now I'll only need to draft new releases?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

Yup, add features, edit versionName X.Y and versionCode ZZZ then Tag vX.Y

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

/close this

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

@licaon-kter how long does it take before the update appears on F-Droid?
Also, if I use auto-update, how can I know wether the build went fine or if it ended up with an error?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

Build process almost realtime (UTC): https://f-droid.org/wiki/index.php?title=Special:RecentChanges&days=7&from=&hidebots=0&hideanons=1&hideliu=1&limit=500

Last build log for your app: https://f-droid.org/wiki/index.php?title=ohi.andre.consolelauncher/lastbuild&redirect=no

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Thank you

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

@licaon-kter Hello, unfortunately the last release didn't appear in f-droid. Could you help me to understand what's the problem?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

You've introduced gradle flavours and the metadata needs to be adapted.

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Thank you. How can I do that?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

Ok so, gradle flavour is the issue, fdroidbot won't detect versionCode

Ref: https://gitlab.com/fdroid/fdroidserver/issues/420

Issue aside, why do you want them different?

/LE: https://gitlab.com/fdroid/fdroiddata/commit/f7d931d01ab44d1dce75827a130ccf980cf51bef

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Since Google started to block apps which use SMS permission, I had to split t-ui in two versions (fdroid and playstore) in order to provide two manifest file (the fdroid one with the permission).
Should I wait replies from that thread?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

Should I wait replies from that thread?

No

Ok, split them, that was not my question, why do you need a different versionCode for F-Droid? How does that help with SMS?

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Because the F-Droid version will probably get some updates before the play store version. If it's a problem I can find an other solution.

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

It's not a problem per se, but it (now) breaks autoupdates.

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Do you think that there is a chance to fix this issue?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

No idea

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

So, I'm going to unify the versionCodes. Is it a problem if I do it now? Is someone checking at the code?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

The faster the better ;)

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

How is it going now?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

Ref: https://gitlab.com/fdroid/fdroiddata/commit/122d5faed62ad65bbe534f83c82b6e68d36776c9

I see that now the versionName is vX.Y and Tag is vX.Y, as said above please keep it consistent and don't change it yet again in the future (eg. in the past versionName was X.Y but Tag was either X.Y or vX.Y), else autoupdate will break yet again.

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Actually it's v6.13.1, should I change something?

from tui-consolelauncher.

licaon-kter avatar licaon-kter commented on September 21, 2024

No, that's my point. :)

from tui-consolelauncher.

fandreuz avatar fandreuz commented on September 21, 2024

Thank you very much!

from tui-consolelauncher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.