Handle InfluxDB::Errors Properly about fluent-plugin-influxdb HOT 7 CLOSED

Hmm... it means your record is {"time":"...","k1":"v1",...}?

from fluent-plugin-influxdb.

Yes, my record was that. I fixed it, but td-agent went into a state where it would no longer send any requests. I had to restart td-agent after that to get it to start working again.

from fluent-plugin-influxdb.

I just wrote a simple patch for this case.
Could you test a patch?

from fluent-plugin-influxdb.

@repeatedly I tested it and it works. You can merge the other PR.

I think it'd be nice though to handle the error states a little more intelligently and drop the messages that are permanent errors.

from fluent-plugin-influxdb.

I think it'd be nice though to handle the error states a little more intelligently and drop the messages that are permanent errors.

I agree but influxdb-ruby seems to raise InfluxDB::Error with error message from influx database.
Do you have a list of error messages?

from fluent-plugin-influxdb.

I do not have a complete list of error messages, but I think a good starting point would be the influxdb-ruby errors.

https://github.com/influxdb/influxdb-ruby/blob/daab9282427641cb222d0939c2f78882c0ec14d5/lib/influxdb/errors.rb

JSONParserError and AuthenticationError are fatal errors and the data should not be resent. The others we can flush out in further iterations of the plugin.

from fluent-plugin-influxdb.

JSONParserError

It doesn't appear in influxdb code.

AuthenticationError

Hmm... how about calling get_database_list like API to check user/password at start phase?
If failed, fluentd doesn't start.

from fluent-plugin-influxdb.