Comments (7)
Hm, interesting: https://github.com/aaFn/Bookmark-search-plus-2/blob/master/sidebar/favicon.js
This looks not trivial and is happening in a background worker. This extension does not do any background tasks, so I'm not sure if I want to change that. I'll have to think about it.
from search-bookmarks-history-and-tabs.
Hi @N3C2L ,
I agree, it would really be a nice addition. If I remember right, the problem was not so much that this isn't possible, but that it works differently for browsers. The examples you sent, are all Firefox specific extensions. This extension here is built in a way that it works for all kind of different browsers (Chrome, Firefox, Edge, Opera, ...).
It doesn't mean that it's not possible to implement this feature, just that it may be more effort. Last time I tried, I also had an issue that the feature how to do that wasn't even properly documented on the browsers side.
from search-bookmarks-history-and-tabs.
I understand. I am not a dev, but madprops, the dev of the grasshopper plugin said, that he uses google favicon urls to retrieve the favicons. He said the other two extensions saving images to local storage for the favicons. Maybe some of these solutions can be used for other browsers as well, but I don't know.
from search-bookmarks-history-and-tabs.
yeah, problem is - I'm not sure if I can introduce that without introducing a new permission, which would not be so nice for the upgrade. But I just didn't find enough time to figure those things out.
Here a while ago I started trying it out, but got stuck on some point: #62
from search-bookmarks-history-and-tabs.
Thanks for considering adding favicons in the future!
May I ask you some additional thing to my observations?
- In the search result page the keys for pageup+pagedown have no function. This would be nice to have options for next/prev page actions.
- I'd love to change some more CSS (for example tab height, position or hiding some things) to the appearance. Is it possible to use your JSON/YAML option for changing existing CSS which is not listed already here:
https://github.com/Fannon/search-bookmarks-history-and-tabs/blob/main/popup/js/model/options.js
?
from search-bookmarks-history-and-tabs.
1): Good point, I haven't thought about that, but this is reasonable to add. Would you expect that it scrolls the entire visible page?
2) Unfortunately that's not so easy or at least I fear that this would lead to "flickering". The CSS of the extension loads very early, together with the extension. Later the JavaScript runs. So if the options change the CSS via JavaScript it would change the layout while or after it has been rendered. Not really sure if it's a problem or not.
If you really want to change the CSS and you feel up to it, you could download this repository source code, follow the developer installation steps, build the extension with your CSS adjustments. Then you can load it in your browsers as a local extension in dev mode and customize as much as you like.
from search-bookmarks-history-and-tabs.
- Yes, that would be great.
- Thank you, I'll keep that in mind. However, there might be another CSS solution, namely a custom text box area like in this plugin: https://github.com/babyman/quick-tabs-chrome-extension/tree/master/3rdParty/css. It could possibly be added to your addon as a separate "CSS" button next to the current "OPTIONS" button at the bottom, which would activate this CSS text box area for inserting CSS (or perhaps a separate button within the "OPTIONS" page).
from search-bookmarks-history-and-tabs.
Related Issues (20)
- Indicator color & Popup window width HOT 13
- Keep last search result selected HOT 2
- Feature request: search bookmark folder to bookmark current tab in it or create new folder in this returned folder to bookmark current tab inside it HOT 2
- Extension for Brave HOT 2
- Getting errors HOT 8
- Remove "hybrid" search
- ColorStripe and BookmarkColor HOT 2
- Separator Line between Bookmarks and History HOT 4
- Search Through Older History HOT 3
- Deps updates since commit 86ee9c6 cause CJK characters *fuzzy* search throw error message of "undefined" HOT 12
- multiple languages support? HOT 6
- Limit (vertical) size of link title
- I like it HOT 4
- How to search inside a specific bookmark folder HOT 10
- Feature request: Vim based navigation instead of arrow keys to move up and down HOT 5
- Open URL in current tab is not working HOT 3
- Arc (chromium) Browser: Cannot open "Options" or "Tips" pages HOT 3
- Can't open a PDF file saved as a bookmark in edge browser. HOT 2
- [Feature Request] Search Folder HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from search-bookmarks-history-and-tabs.