Giter VIP home page Giter VIP logo

Comments (7)

Fannon avatar Fannon commented on May 16, 2024 3

@dimateos : I've played around with this a little, but unfortunately there are quite a few challenges to make this work nicely.

First, I can't add a new permission 'favicon' without having the extension be disabled for all users after the update. I can make it an optional permission, but then I need to implement logic to ask for permission on demand (which would be a fair approach, though).

For tabs, I got it working, but for bookmarks and history it's a bit weird. Haven't found any official API documentation for this. Some old way of accessing it has been deprecated, but the new approach seems to not be fully worked out yet. Generally, if this extension is to work for all browsers, I'm not sure how well (and similar) the favicon feature would work across those.

This is how it could look like:

image

I'll keep this feature in mind, as it would be very nice. But unfortunately, to get this done properly I would need to invest more time.

Relevant Links / Material

from search-bookmarks-history-and-tabs.

Fannon avatar Fannon commented on May 16, 2024

Hi Dimateos,

thanks!
Yes, I see your point and it would be a good addition to the extension.
First I didn't add it because I did not want the extension to do any outside requests and keep it very minimalistic and fast. I would like to avoid that opening the search bar results in dozens of HTTP requests. But maybe those icons are already somewhere available in a cached form? At least it's worth a try, when I have some time to look into it.

from search-bookmarks-history-and-tabs.

dimateos avatar dimateos commented on May 16, 2024

Great!

I dont know much about web/chrome, maybe the url site/favicon is already cached and it is just solved instantly. It could also be an option unset by default if it worries you.

Anyway thanks for looking into it whenever you have time!

from search-bookmarks-history-and-tabs.

gbsix avatar gbsix commented on May 16, 2024

I'm expecting the icon feature, too! Thank you!

from search-bookmarks-history-and-tabs.

Fannon avatar Fannon commented on May 16, 2024

I'm expecting the icon feature, too! Thank you!

Yeah, it would be really nice. Would like to have it myself :)

But it looks like it might take some more time for the major browser makers to support this stable with the new Manifest v3 standard.

But other people are also asking for it. Seems like API documentation is completely missing. I could also just try around with examples, which were also not always in sync with each other. Confusing situation.

https://stackoverflow.com/questions/65846725/i-cant-find-any-documentation-for-chrome-favicon-api

from search-bookmarks-history-and-tabs.

gbsix avatar gbsix commented on May 16, 2024

I'm expecting the icon feature, too! Thank you!

Yeah, it would be really nice. Would like to have it myself :)

But it looks like it might take some more time for the major browser makers to support this stable with the new Manifest v3 standard.

But other people are also asking for it. Seems like API documentation is completely missing. I could also just try around with examples, which were also not always in sync with each other. Confusing situation.

https://stackoverflow.com/questions/65846725/i-cant-find-any-documentation-for-chrome-favicon-api

I wonder if you could get some insights from this similar extension, github page. I used this ext before switching to yours, it's super fast and good to use, too.

from search-bookmarks-history-and-tabs.

paragbaxi avatar paragbaxi commented on May 16, 2024

I often have a project that uses a gdoc for the summary, and gsheet for the data. I name them almost identically. This feature would really help clarify which match is the gdoc and which one is the gsheet.

I'll keep this feature in mind, as it would be very nice. But unfortunately, to get this done properly I would need to invest more time.

I would love to code to contribute but I also lack the time. I've seen other open source projects successfully attract talent with time available through bounties or tipjars. I'm not sure if this is something you're willing to consider.

Cheers!

from search-bookmarks-history-and-tabs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.