Bug in skip_frame feature about arcade-learning-environment HOT 7 CLOSED

Thanks for pointing this issue out! I think the best way of handling it would be to change the applyActions method in ale_controller to return a reward_t (probably zero for reset/save/load actions) which is the reward it got from environment.act(). The associated fifo/internal/rl_glue controllers would have to be changed as well.

It seems to me that it would be preferable to use the StellaEnvironment to get rewards wherever possible rather than going under stella environment and calling m_settings->getReward(). What do you think Marc?

from arcade-learning-environment.

That's exactly what I ended up doing in my local copy, and it seems to work fine. If you want, I'm happy to pass along my fixed ale_controller. My version of the rl_glue controller has the fix as well, but it is horribly hacked up in other ways, so I doubt you would want that. Nice work on ALE by the way! Thanks for distributing it.

from arcade-learning-environment.

I've written some code to fix the issue and submitted it as a pull request to the repo. It sounds like you've already fixed the code on your end so worries there. Hopefully the code in the pull request is basically the same as your fixed ale_controller. Take a look if you want and let me know if anything doesn't look right. Thanks for reporting the bug!

from arcade-learning-environment.

The changes look correct to me. Thanks for working on a fix.

from arcade-learning-environment.

Can this issue be closed?

from arcade-learning-environment.

Yes
On Aug 12, 2013 10:52 AM, "Marc G. Bellemare" [email protected]
wrote:

Can this issue be closed?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/18#issuecomment-22503222
.

from arcade-learning-environment.

I closed it.

On 08/12/2013 11:50 AM, Marc G. Bellemare wrote:

Can this issue be closed?

—
Reply to this email directly or view it on GitHub
#18 (comment).

from arcade-learning-environment.