SDL/SDL.h not found when compiling with cmake -DUSE_SDL=ON about arcade-learning-environment HOT 4 CLOSED

Here is the summary of SDL includes in the current codebase:

./doc/examples/sharedLibraryInterfaceExample.cpp:21:  #include <SDL.h>
./src/emucore/SpeakJet.hxx:85:#include <SDL.h>
./src/common/SoundSDL.hxx:26:#include <SDL/SDL.h>
./src/common/display_screen.h:28:#include "SDL/SDL.h"
./src/common/SoundSDL.cxx:24:#include <SDL/SDL.h>

So it looks like we have had for a long time a mix of SDL.h and SDL/SDL.h.

Also, we should change the display_screen.h include to use brackets instead of quotes. This may be the culprit.

from arcade-learning-environment.

The quotes isn't the culprit, unfortunately. On a related note, SpeakJet
isn't used by ALE (it has to do with the AtariVox), so we could consider
chucking it out.

On Fri, Apr 24, 2015 at 8:00 PM, Matthew Hausknecht <
[email protected]> wrote:

Here is the summary of SDL includes in the current codebase:

./doc/examples/sharedLibraryInterfaceExample.cpp:21: #include <SDL.h>
./src/emucore/SpeakJet.hxx:85:#include <SDL.h>
./src/common/SoundSDL.hxx:26:#include <SDL/SDL.h>
./src/common/display_screen.h:28:#include "SDL/SDL.h"
./src/common/SoundSDL.cxx:24:#include <SDL/SDL.h>

So it looks like we have a mix of and .

Also, we should change the display_screen.h include to use brackets
instead of quotes. This may be the culprit.

—
Reply to this email directly or view it on GitHub
#52 (comment)
.

from arcade-learning-environment.

Do we feel this is resolved?

from arcade-learning-environment.

Using -sdl-config to generate the include paths has solved this issue.

from arcade-learning-environment.