Giter VIP home page Giter VIP logo

Comments (6)

elliottower avatar elliottower commented on May 29, 2024 1

We’re about to release a new pettingzoo version and update chess but I’m not sure why this repo hard codes that chess version. @yuxiang-wu did this get done on purpose or was it just the version you happened to have installed or something?

from chatarena.

jas-ho avatar jas-ho commented on May 29, 2024

thanks for answering! if it's fixed by an upcoming pettingzoo release anyways then that's good enough imo

from chatarena.

elliottower avatar elliottower commented on May 29, 2024

This was fixed in PettingZoo 1.24.0, but ChatArena needs to be updated to use the latest version

from chatarena.

elliottower avatar elliottower commented on May 29, 2024

I think the simplest solution to this actually would be to remove the requirement for chess altogether and just let the requirement say pettingzoo[classic], as that installs chess no matter what--in pettingzoo v23 it installs an older version of chess, and in v24 it installs the newest one 1.9.4

from chatarena.

elliottower avatar elliottower commented on May 29, 2024

Posting this here as it's related, but the setup.py and pyproject.toml files are not matching and make each other redundant, both require the same extras but in pyproject I believe I removed the chess requirement but didn't do it in setup.py ( https://github.com/chatarena/chatarena/blob/fa6b374bb62fa7070454962eec6a9c88bc584d63)

It looks like there's some custom logic used in setup to remove duplicate requirements and such, so maybe it's best to keep the requirements in setup.py and use pyproject for metadata and setup? I can do this in the future and clean things up but don't have time currently/setup.py#L25)

from chatarena.

elliottower avatar elliottower commented on May 29, 2024

This has been fixed as well

from chatarena.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.