Giter VIP home page Giter VIP logo

Comments (4)

maximecb avatar maximecb commented on July 4, 2024

I agree that if there is a text-based format, it should mirror the format from the __str__ method. We may want to change the symbols used to represent the agent though, as they are non-ASCII and hard to type on a keyboard.

For creating envs with parameters, the way to do this is to import them directly, eg: from minigrid.envs import TextFileEnv(file_name).

I'm going to ask the obvious question though: do you personally have a need for this feature? Would you make use of it. Because it's not that hard to create environments just by writing code, so unless you actually have a legitimate use for this, I would say YAGNI?

from minigrid.

d3sm0 avatar d3sm0 commented on July 4, 2024

I agree that if there is a text-based format, it should mirror the format from the __str__ method. We may want to change the symbols used to represent the agent though, as they are non-ASCII and hard to type on a keyboard.

For creating envs with parameters, the way to do this is to import them directly, eg: from minigrid.envs import TextFileEnv(file_name).

I'm going to ask the obvious question though: do you personally have a need for this feature? Would you make use of it. Because it's not that hard to create environments just by writing code, so unless you actually have a legitimate use for this, I would say YAGNI?

Thanks it seems like we do need this feature.

from minigrid.

maximecb avatar maximecb commented on July 4, 2024

One thing we should do for this feature is have some round-trip testing. Grid to text, then parse the text back into a grid, and make sure the two versions are identical. I would implement all of the __str__ and parsing functionality into the grid class. That will also require us to treat agents as world objects, in order to parse the agent position as well.

from minigrid.

maximecb avatar maximecb commented on July 4, 2024

Closing for now.

from minigrid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.