Bug: agent's view rectangle calculation about minigrid HOT 3 CLOSED

I'd be inclined to add an assert to disallow even view sizes. Do you have a use case in mind where that's genuinely useful?

from minigrid.

Well, that's a good idea too. Why I didn't think of it in first place making bug fix PR? :( I just haven't seen any mentions that it was supposed to be odd and thought/acted accordingly.

For me it's useful to have more granularity at choosing view size during initial hack-n-debug with an agent - when you play with simple small size environments and hence small view sizes, because such granularity makes sense only in a case of small sizes. I'd even thought of an option to set rectangular view area.

Of course, it's not mandatory and not critical at all. And, even more, you can crop observation manually with a custom observation wrapper - which will do the work except for the rendering (which is fine).

from minigrid.

I've added assertions to check that the view size is odd and >= 3. Sorry for rejecting the PR.

from minigrid.