Crash related to NetBox about farmanager HOT 6 CLOSED

@michaellukashov fyi

from farmanager.

Far has a problem here because it never calls FreeLibrary. So any plugin that undergoes far.ForcedLoadPlugin / far.UnloadPlugin won't be unloaded from the address space of the process (DllMain of the plugin will get exactly one DLL_PROCESS_ATTACH at the first load and one DLL_PROCESS_DETACH at the Far termination).

This results in global / static local variables not being cleared on reload. So it's worth fixing this on Far's side.

from farmanager.

it never calls FreeLibrary

from farmanager.

NetBox/libs/openssl-3/crypto/init.c:

        ret = GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS
                                | GET_MODULE_HANDLE_EX_FLAG_PIN,
                                (void *)&base_inited, &handle);

I hope it is obvious what is going on.

If you want FreeLibrary to work, you need to tell OpenSSL to stop pinning the whole thing by defining OPENSSL_NO_PINSHARED.

from farmanager.

it never calls FreeLibrary

I made that quick assumption just by observing DllMain calls and an obvious case that LoadLibrary / FreeLibrary should work normal. That was wrong. So, it's time to look at Far's sources more thoroughly ;)

@alabuzhev thanks for you time.

from farmanager.

3.0.6304 comes with a fixed NetBox.

from farmanager.