Comments (2)
Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):
One thing I noticed from the XML schema was the regex being used for the names of drawing objects. It appears that an underscore ‘_’ is valid as part of a name. This would seem to conflict with the requirement to parse line length references within formula. E.g.
I create some points with names: ‘A’, ‘A_B’, ‘B’, ‘B_C’ and ‘C’. I then draw a line between ‘A_B’ and ‘C’ This gives a line reference that I can use in formula ‘Line_A_B_C’ I then create a second line between ‘A’ and ‘B_C’. This also has a line reference that I can use in formula 'Line_A_B_C’ This is therefore ambiguous.
The easiest fix would be to disallow underscore from object names. In fact, the problem is even easier to reproduce if I label a point ‘Line_A_B’, though I am less likely to do that by accident. This doesn’t cause a failure, Valentina just silently uses the first value that provides that name, however this could be very confusing, especially if the values were similar.
from seamly2d.
won't fix, see discussion in issue #44. Custom user-defined math functions aren't easily implementable in qmuparser.
from seamly2d.
Related Issues (20)
- BUG: Dialog layout issues with MacOS builds and translated text.
- BUG: Error crítico en Seamly2d. No puedo abrir el archivo. HOT 4
- BUG: All Buttons Grayed Out HOT 4
- Feature: Make variables available global in a project HOT 1
- Feature: improve the point intersect arc and line tool icon and cursor.
- BUG: incorrect shortcut tooltips
- Feature: code styling change of increment to (custom) variable
- BUG: default piece label template is using default pattern label template
- BUG: Operations toolbar greyed out
- BUG: Point - Intersect arc and line icon missing
- Feature: enhance and update the About dialog
- Feature: Add Images to groups
- Feature: Enable Undo and Redo for images
- Feature: Background Images Origin Tool HOT 1
- Feature: Saving background images
- Feature: Automatic resizing of images using a reference length
- Feature: Automatic perspective correction tool for background images
- Refactor: Add an ImageTool class
- Build: Windows signing certificate expired HOT 2
- BUG: field order differs between property editor and dialog for interactive curve tool
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seamly2d.