Giter VIP home page Giter VIP logo

Comments (14)

sconklin avatar sconklin commented on July 26, 2024

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Merged in ValentinaZhuravska/valentina/feature (pull request #81)

Resolved issue #80.

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Resolved issue #80. Choice between inches and centimeters in options

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Merged in ValentinaZhuravska/valentina/feature (pull request #81)

Resolved issue #80.

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Susan Spencer (Bitbucket: suzynumena, GitHub: Unknown):


Agree

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Good idea still, but hard to implement in current state.

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Problem is that they want full conversion and we can't give them this now.

Even if write height0.5+10cm+25cm conversion mean rewrite each formula to height0.5+3.937in+9.8425in. And after this you will feel full advantage of conversion. In SVG you can make such because you use parametric values in objects. In our case such big changes in formula can broke formula.

What if not make formula conversion? Ok. But after user choose inches he will begin type in inches and add for example + 5in to formula. What we have in this case? In formula we have several units at the same time. Bad idea. :(

Parsing formula already big task, but add conversion need too much time and testing that we don't have now. But i don't say that it is not possible. :) So just not now.

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Susan Spencer (Bitbucket: suzynumena, GitHub: Unknown):


It's not too much to ask a user to state cm or in.
These are patternmakers, they use math!

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Choose unit carefully before creation pattern. This is situation where two standards (cm and inch) can't be converted without additional information.

Example: height0.5+10+25.

heights is variable and can be translated, but what about 0.5, 10, 2 and 5. Inch or cm? Only simple rule will work.

Formula height0.5+10cm+25cm can be translated. I don't think user will like such way write formulas.

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Susan Spencer (Bitbucket: suzynumena, GitHub: Unknown):


So what do we recommend to the user? We don't want anyone to be confused.

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


We decided don't do that. New math parser allow user write 1mm or 2in, but still it is not fix problem like we want. Nature of pattern formulas don't allow do that smoothly for user.

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


New math parser allow add this feature.

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Susan Spencer (Bitbucket: susanlspencer, GitHub: Unknown):


This item appears to still be under discussion.

from seamly2d.

sconklin avatar sconklin commented on July 26, 2024

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


It is not posible.

from seamly2d.

slspencer avatar slspencer commented on July 26, 2024

Currently measurements are displayed in the units of the pattern, regardless of the units of the measurements.
This issue is closed.

from seamly2d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.