fastcore.utils.Tuple is not a replacement for typing.Tuple about fastcore HOT 4 CLOSED

Can you explain more about what you mean here? I don't see how fastcore.utils.Tuple "shadows" typing.Tuple. They have the same class name, but they are in different modules. typing.Tuple is still available as typing.Tuple, so it's not shadowed, AFAICT. You can still from typing import Tuple if you wish.

fastcore.utils.Tuple is not intended to be a replacement for typing.Tuple.

IIUC, what you're really saying is that fastai shouldn't name a class with the same name as a class in stdlib. I'm not sure if there's really a justification for that rule, in general.

I'm quite possibly missing something though, so please do let us know more about what specific concerns you have.

from fastcore.

@jph00, thanks for the response. I should have clarified this better:

In [1]:
from fastai2.basics import *

In [2]:
Tuple
Out [2]:
fastcore.utils.Tuple

IIUC, what you're really saying is that fastai shouldn't name a class with the same name as a class in stdlib. I'm not sure if there's really a justification for that rule, in general.

I agree that typing.Tuple is not automatically shadowed, and that it is easy to import typing.Tuple explicitly. But this kind of error is surprising, it could be avoided.

I'm suggesting that since fastai encourages the import * style, it should be extra careful about default exporting names that conflict with stdlib (or other common data science libraries).

(Just as a separate data point, I've been bitten similarly recently where I had a function named one_hot and then something changed -- either I did another import * or pulled master, or I ran cells in a different order than before -- but fastai2's one_hot was shadowing mine and it took some time to figure that out. I realize that this is a natural risk of import * that you've probably considered, that fastai can't avoid naming things like one_hot, but it makes for a slightly more frustrating developer experience.)

from fastcore.

Thanks for pointing this out. Now renamed to fastuple.

from fastcore.

Thanks, I appreciate you taking the time to fix this (and everything else you do with fastai!).

from fastcore.