Bind 0.0.0.0 in docker env about fastify-cli HOT 7 CLOSED

it's a sensible thing to do if by default we want a working service limiting options and arguments when running in docker

from fastify-cli.

I do not think you are running your server using fastify-cli. Are you using this module at all?

The snippet above is not from this module.

from fastify-cli.

I think something is broken here.

fastify.listen(process.env.PORT || 3000, '0.0.0.0', function (err, address) {
	if (err) {
		fastify.log.error(err)
		process.exit(1)
	}
	fastify.log.info(`server listening on ${address}`)
});

When running on regular Node I get Server listening on http://0.0.0.0:3000 as expected.

But when running in Docker I get Server listening at http://127.0.0.1:8080 so the server cannot be reached.

Wasn't this PR by @mcollina supposed to add 0.0.0.0 by default when running in Docker?

#58

It seems now it's actually overwriting the address and using 127.0.0.1 instead.

Or maybe I'm missing something...

from fastify-cli.

I would do this by default if bundled within docker.

from fastify-cli.

Closed in #58

from fastify-cli.

Damn'it I'm too late. Just ran into it when using docker. Would have been easier if I had seen this earlier.

from fastify-cli.

Ooops sorry @mcollina I totally missed this wasn't the main Fastify repo.

from fastify-cli.