folders without trailing slash hang fastify about fastify-static HOT 5 CLOSED

I think there is some bug somewhere, the 404 handler is never reached for the /css as you notice.

Tried also ignoreTrailingSlash config

'use strict'

const Fastify = require('fastify')
const path = require('path')

const app = Fastify({ logger: true, ignoreTrailingSlash: true })

app.register(require('fastify-static'), {
  root: path.join(__dirname, 'public')
});

app.setNotFoundHandler((request, reply) => {
  app.log.warn('404')
  reply.send('404')
})

app.listen(3000)

from fastify-static.

I can reproduce this on older commits (e.g., 43706ca) , but not on latest master. I think this is fixed.

from fastify-static.

@mcollina The bug still exists

I was able to reproduce when using an array for the root ie:

const app = Fastify({ logger: true, ignoreTrailingSlash: true })

app.register(require('fastify-static'), {
  root: [path.join(__dirname, 'public'), path.join(__dirname, 'test')]
});

In my case using an array caused issue, when i used

root: arrayOfFolders[0],

It didnt hang.

I'm using gz compression and othering

from fastify-static.

Please open a fresh issue with a example to reproduce, a github repo is ok.

from fastify-static.

A PR to fix would also be nice.

from fastify-static.